Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some update for vxWorks #63604

Merged
merged 2 commits into from
Aug 16, 2019
Merged

Some update for vxWorks #63604

merged 2 commits into from
Aug 16, 2019

Conversation

BaoshanPang
Copy link
Contributor

@BaoshanPang BaoshanPang commented Aug 15, 2019 •
edited
Loading

  1. support crt-static
  2. change armv7_wrs_vxworks to armv7_wrs_vxworks_eabihf.
  3. change vx-cxx to wr-c++, vx-ar to wr-ar and vx-run to wr-run.
  4. code cleanup

r? @alexcrichton

bpangWR and others added 2 commits August 13, 2019 22:07
@bpangWR
1. support crt-static
f161efa 
2. change armv7_wrs_vxworks to armv7_wrs_vxworks_eabihf.
3. use wr-** instead of vx-**
4. set PIE to false
5. code cleanup
@BaoshanPang
Merge pull request #1 from Wind-River/vxworks_bpang_static
403e672 
update for vxWorks
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 15, 2019
@n-salim n-salim mentioned this pull request Aug 15, 2019
Merged
@BaoshanPang
Copy link
Contributor Author

@alexcrichton

We are supporting vxWorks targets in two modes:
pure static linking and pure dynamic linking.

The pure static linking is by default, if user doesn't specify any of "-C perfer-dynamic" or "-C target-feature=-crt-static", everything is statically linked into the executable, no shared library will be used.
For pure dynamic linking, the user has to specify both "-C perfer-dynamic" and "-C target-feature=-crt-static", then all libraries will be used in dynamic form, no static library will be linked into executable.

We are thinking about to make it easier to user for "pure dynamic linking":
When user specify "-C perfer-dynamic" then "-C target-feature=-crt-static" would be used automatically, and vice versa, i.e. tie the two options together. Can you give some suggestion how should we implement it?

Thanks,
Baoshan

@alexcrichton
Copy link
Member

@bors: r+

Unfortunately static linking vs dynamic is pretty tricky in Rust (I think it's just tricky in general in terms of having tons of config over a build process) and we don't have great solutions right now. I don't have many recommendations one way or another, sorry :(

@bors
Copy link
Contributor

bors commented Aug 16, 2019

📌 Commit 403e672 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 16, 2019
Centril added a commit to Centril/rust that referenced this pull request Aug 16, 2019
@Centril
Rollup merge of rust-lang#63604 - Wind-River:master, r=alexcrichton
b731131 
Some update for vxWorks

1. support crt-static
2. change armv7_wrs_vxworks to armv7_wrs_vxworks_eabihf.
3. change vx-cxx to wr-c++,  vx-ar to wr-ar and vx-run to wr-run.
4. code cleanup

r? @alexcrichton
@Centril Centril mentioned this pull request Aug 16, 2019
Merged
bors added a commit that referenced this pull request Aug 16, 2019
@bors
Auto merge of #63640 - Centril:rollup-yeb8o66, r=Centril
bdfd698 
Rollup of 10 pull requests

Successful merges:

 - #60492 (Add custom nth_back for Chain)
 - #61780 (Finalize the error type for `try_reserve`)
 - #63495 ( Remove redundant `ty` fields from `mir::Constant` and `hair::pattern::PatternRange`.)
 - #63525 (Make sure that all file loading happens via SourceMap)
 - #63595 (add sparc64-unknown-openbsd target)
 - #63604 (Some update for vxWorks)
 - #63613 (Hygienize use of built-in macros in the standard library)
 - #63632 (A couple of comment fixes.)
 - #63634 (ci: properly set the job name in CPU stats)
 - #63636 (ci: move linkcheck from mingw-2 to mingw-1)

Failed merges:

r? @ghost
@bors bors merged commit 403e672 into rust-lang:master Aug 16, 2019
@bors
Copy link
Contributor

bors commented Aug 16, 2019

☔ The latest upstream changes (presumably #63640) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 16, 2019
@BaoshanPang
Copy link
Contributor Author

Do I need to do anything for this PR? I see the code has been merged into master branch:

b731131

@alexcrichton
Copy link
Member

Nah you're good, this is just a bug in bors saying that it needs a rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BaoshanPang @rust-highfive @alexcrichton @bors @bpangWR