Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add methods for converting bool to Option<T> #64255

Merged
merged 4 commits into from
Sep 8, 2019
Merged

Add methods for converting bool to Option<T> #64255

merged 4 commits into from
Sep 8, 2019

Conversation

varkor
Copy link
Member

@varkor varkor commented Sep 7, 2019 •
edited
Loading

This provides a reference implementation for rust-lang/rfcs#2757.

@varkor varkor mentioned this pull request Sep 7, 2019
Closed
@Centril
Copy link
Contributor

Centril commented Sep 7, 2019

r? @Centril

@rust-highfive rust-highfive assigned Centril and unassigned KodrAus Sep 7, 2019
@varkor varkor marked this pull request as ready for review September 7, 2019 15:18
Centril
Centril reviewed Sep 7, 2019
View reviewed changes
Copy link
Contributor

@Centril Centril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to land this as unstable for now before the RFC has landed.

r=me rollup with review comments addressed.

src/libcore/bool/mod.rs Outdated Show resolved Hide resolved
src/libcore/lib.rs Outdated Show resolved Hide resolved
src/libcore/bool/mod.rs Outdated Show resolved Hide resolved
@varkor varkor mentioned this pull request Sep 7, 2019
Closed
@Centril
Copy link
Contributor

Centril commented Sep 7, 2019

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 7, 2019

📌 Commit 7b3f729 has been approved by Centril

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 7, 2019
Centril added a commit to Centril/rust that referenced this pull request Sep 7, 2019
@Centril
Rollup merge of rust-lang#64255 - varkor:bool-to-option, r=Centril
cd3cb28 
Add methods for converting `bool` to `Option<T>`

This provides a reference implementation for rust-lang/rfcs#2757.
@Centril Centril mentioned this pull request Sep 7, 2019
Merged
bors added a commit that referenced this pull request Sep 7, 2019
@bors
Auto merge of #64269 - Centril:rollup-y4dm32c, r=Centril
f7b05af 
Rollup of 5 pull requests

Successful merges:

 - #64052 (Rename test locals to work around LLDB bug)
 - #64066 (Support "soft" feature-gating using a lint)
 - #64177 (resolve: Do not afraid to set current module to enums and traits)
 - #64229 (Reduce span to function name in unreachable calls)
 - #64255 (Add methods for converting `bool` to `Option<T>`)

Failed merges:

r? @ghost
@bors bors merged commit 7b3f729 into rust-lang:master Sep 8, 2019
@varkor varkor deleted the bool-to-option branch September 8, 2019 08:24
@KodrAus KodrAus mentioned this pull request Jan 13, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Centril Centril Centril left review comments

Assignees

@Centril Centril

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@varkor @Centril @bors @KodrAus