Delete most of src/bootstrap/bin/rustc.rs
#64316
Commits on Sep 23, 2019
-
bootstrap: Add a helper for managing RUSTFLAGS
Most of `bootstrap/bin/rustc.rs` doesn't need to exist with the advent of `RUSTFLAGS` (yes this is super old) so this starts by refactoring a bit to make it easier locally in the `Builder::cargo` method to append to `RUSTFLAGS` that gets down to rustc.
-
bootstrap: Delete handling of
RUSTC_METADATA_SUFFIXThis is already handled by `__CARGO_DEFAULT_LIB_METADATA` so there's no need to doubly do it.
-
bootstrap: Move
RUSTC_BREAK_ON_ICEout of shimThis is always set, so let's just always set it elsewhere to reduce the need for our `rustc.rs` shim.
-
bootstrap: Move
-Zexternal-macro-backtraceto builderNo need for this to be in `rustc.rs`
-
-
bootstrap: Remove usage of
RUSTC_TARGET_LINKERCargo has a native enviroment variable for this.
-
-
-
bootstrap: Handle target-specific cargo env vars
This commit ensure that we handle target-specific env vars for RUSTFLAGS through Cargo as well.
-
-
-
-
-
-
-
-
Allow adding
RUSTFLAGSafterBuilder::cargoThis commit changes the return type of `Builder::cargo` to return a builder that allows dynamically adding more `RUSTFLAGS` values after-the-fact. While not used yet, this will later be used to delete more of `rustc.rs`
-
Move handling of
{MUSL,WASI}_ROOTtocompile.rsNo longer any need for them to live in `rustc.rs`!
-
Move handling of
RUSTC_PARALLEL_COMPILERtocompile.rsNo longer needs to live in `rustc.rs`
-
Move
--cfg bootstrapout ofrustc.rsInstead let's do this via `RUSTFLAGS` in `builder.rs`. Currently requires a submodule update of `stdarch` to fix a problem with previous compilers.
-
Move handling of
-Cprefer-dynamicintobuilder.rsThis logic is *super* old and can be tweaked and moved into `builder.rs`
-
-
-
Fix compiling libserialize tests
They've got new warnings turned on so they need more `#![allow]`
-
-
No need to remove target-specific RUSTFLAGS
Turns out Cargo favors RUSTFLAGS!
-
-
rustbuild: Pass
-Zsave-analysisduring testsThis is needed to ensure that the crates during a normal build are shared with the crates during testing, otherwise they'll end up hasing differently and we'll recompile crates like `core` during tests.
-
Remove
--enable-extendedfrom cross dist builderShouldn't have an effect on produced artifacts and otherwise is causing issues where `-Zsave-analysis` is passed during tests but fails compilation.
-
