Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make it possible to add args to cargo in x.py #65129

Merged
merged 1 commit into from
Oct 10, 2019
Merged

make it possible to add args to cargo in x.py #65129

merged 1 commit into from
Oct 10, 2019

Conversation

andjo403
Copy link
Contributor

@andjo403 andjo403 commented Oct 5, 2019

eg. make it easier to test -Ztimings for rustc

cc #65088

@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 5, 2019
@rust-highfive

This comment has been minimized.

Sign in to view
@andjo403
Copy link
Contributor Author

andjo403 commented Oct 5, 2019

some day I will learn to commit before I run the tests so I do not get this kind of faults

@alexcrichton
Copy link
Member

Thanks! Is this something where we want to add CARGOFLAGS as well for future use?

@andjo403
Copy link
Contributor Author

andjo403 commented Oct 8, 2019

I'm not sure what you mean. is there an CARGOFLAGS that I shall use? or shall it be added to cargo?

@alexcrichton
Copy link
Member

Oh I mean this largely in the context of RUSTFLAGS vs RUSTFLAGS_* where CARGOFLAGS would be used to pass flags to all cargo invocations, regardless of the stage.

@andjo403
make it possible to add args to cargo in x.py
6ae36a3 
eg. make it easier to test -Ztimings for rustc
@andjo403
Copy link
Contributor Author

andjo403 commented Oct 9, 2019

added a CARGOFLAGS env var now.

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Oct 9, 2019

📌 Commit 6ae36a3 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 9, 2019
Centril added a commit to Centril/rust that referenced this pull request Oct 9, 2019
@Centril
Rollup merge of rust-lang#65129 - andjo403:cargo_args, r=alexcrichton
8697fb3 
make it possible to add args to cargo in x.py

eg. make it easier to test -Ztimings for rustc

cc rust-lang#65088
@Centril Centril mentioned this pull request Oct 9, 2019
Closed
@bors
Copy link
Contributor

bors commented Oct 10, 2019

⌛ Testing commit 6ae36a3 with merge 8c7b921...

bors added a commit that referenced this pull request Oct 10, 2019
@bors
Auto merge of #65129 - andjo403:cargo_args, r=alexcrichton
8c7b921 
make it possible to add args to cargo in x.py

eg. make it easier to test -Ztimings for rustc

cc #65088
@bors
Copy link
Contributor

bors commented Oct 10, 2019

☀️ Test successful - checks-azure
Approved by: alexcrichton
Pushing 8c7b921 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 10, 2019
@bors bors merged commit 6ae36a3 into rust-lang:master Oct 10, 2019
@andjo403 andjo403 deleted the cargo_args branch October 10, 2019 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andjo403 @rust-highfive @alexcrichton @bors