Disable gdb pretty printer global section on wasm targets #66520

alexcrichton · 2019-11-18T15:41:53Z

The wasm targets don't support gdb anyway so there's no need for this
section there.

rust-highfive · 2019-11-18T15:41:57Z

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

eddyb · 2019-11-18T15:52:24Z

@bors r+

bors · 2019-11-18T15:52:25Z

📌 Commit eda67ba has been approved by eddyb

Disable gdb pretty printer global section on wasm targets The wasm targets don't support gdb anyway so there's no need for this section there.

@ghost

Rollup of 13 pull requests Successful merges: - #66090 (Misc CI improvements) - #66239 (Suggest calling async closure when needed) - #66430 ([doc] Fix the source code highlighting on source comments) - #66431 (Fix 'type annotations needed' error with opaque types) - #66461 (Add explanation message for E0641) - #66468 (Cleanup Miri SIMD intrinsics) - #66478 (rustc_plugin: Remove the compatibility shim) - #66493 (Add JohnTitor to rustc-guide toolstate notification list) - #66511 (std::error::Chain: remove Copy) - #66512 (Add unix::process::CommandExt::arg0) - #66520 (Disable gdb pretty printer global section on wasm targets) - #66529 (resolve: Give derive helpers highest priority during resolution) - #66536 (Move the definition of `QueryResult` into `plumbing.rs`.) Failed merges: r? @ghost

Disable gdb pretty printer global section on wasm targets The wasm targets don't support gdb anyway so there's no need for this section there.

Centril · 2019-11-21T14:27:33Z

Failed in #66604 (comment), @bors r- rollup=never

JohnCSimon · 2019-11-29T01:43:31Z

Ping from triage:
@eddyb - this PR has been squashed passed the checks and has been approved already.
Thank you.

eddyb · 2019-11-29T03:14:02Z

@JohnCSimon nothing happened since #66520 (comment).

alexcrichton · 2019-12-02T15:41:58Z

Oops sorry I missed the notification here about the failed test, I will update this in the next day or so.

alexcrichton · 2019-12-02T21:15:35Z

@bors: r=eddyb

bors · 2019-12-02T21:15:37Z

📌 Commit b8eb6b75ddb63698a575972c1ccf73f678bb526c has been approved by eddyb

bors · 2019-12-04T20:50:59Z

⌛ Testing commit b8eb6b75ddb63698a575972c1ccf73f678bb526c with merge 12eeebd0f5233ed86954459db2d054ebcca48df2...

rust-highfive · 2019-12-04T23:07:04Z

The job wasm32 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-12-04T23:05:46.7156932Z failures:
2019-12-04T23:05:46.7157147Z 
2019-12-04T23:05:46.7157935Z ---- [codegen] codegen/gdb_debug_script_load.rs stdout ----
2019-12-04T23:05:46.7158034Z 
2019-12-04T23:05:46.7158525Z error: verification with 'FileCheck' failed
2019-12-04T23:05:46.7158624Z status: exit code: 1
2019-12-04T23:05:46.7159165Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/llvm/build/bin/FileCheck" "--input-file" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen/gdb_debug_script_load/gdb_debug_script_load.ll" "/checkout/src/test/codegen/gdb_debug_script_load.rs"
2019-12-04T23:05:46.7159554Z ------------------------------------------
2019-12-04T23:05:46.7159617Z 
2019-12-04T23:05:46.7159828Z ------------------------------------------
2019-12-04T23:05:46.7159912Z stderr:
2019-12-04T23:05:46.7159912Z stderr:
2019-12-04T23:05:46.7160122Z ------------------------------------------
2019-12-04T23:05:46.7160229Z /checkout/src/test/codegen/gdb_debug_script_load.rs:11:11: error: CHECK: expected string not found in input
2019-12-04T23:05:46.7160598Z // CHECK: load volatile i8, i8* getelementptr inbounds ([[B:\[[0-9]* x i8\]]], [[B]]* @__rustc_debug_gdb_scripts_section__, i32 0, i32 0), align 1
2019-12-04T23:05:46.7160734Z           ^
2019-12-04T23:05:46.7161077Z /checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen/gdb_debug_script_load/gdb_debug_script_load.ll:22:17: note: scanning from here
2019-12-04T23:05:46.7161179Z define i32 @main(i32, i8**) unnamed_addr #2 {
2019-12-04T23:05:46.7161299Z 
2019-12-04T23:05:46.7161529Z ------------------------------------------
2019-12-04T23:05:46.7161574Z 
2019-12-04T23:05:46.7161605Z 
---
2019-12-04T23:05:46.7162436Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:537:22
2019-12-04T23:05:46.7162544Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-12-04T23:05:46.7162612Z 
2019-12-04T23:05:46.7162662Z 
2019-12-04T23:05:46.7168620Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/wasm32-unknown-emscripten/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/codegen" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen" "--stage-id" "stage2-wasm32-unknown-emscripten" "--mode" "codegen" "--target" "wasm32-unknown-emscripten" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/checkout/obj/build/x86_64-unknown-linux-gnu/llvm/build/bin/FileCheck" "--nodejs" "/emsdk-portable/node/12.9.1_64bit/bin/node" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/wasm32-unknown-emscripten/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--llvm-version" "9.0.0-rust-1.41.0-dev\n" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-12-04T23:05:46.7169496Z 
2019-12-04T23:05:46.7169549Z 
2019-12-04T23:05:46.7181003Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --target wasm32-unknown-emscripten --exclude src/libcore --exclude src/liballoc --exclude src/libproc_macro --exclude src/libstd --exclude src/libterm --exclude src/libtest
2019-12-04T23:05:46.7181187Z Build completed unsuccessfully in 2:09:13
2019-12-04T23:05:46.7181187Z Build completed unsuccessfully in 2:09:13
2019-12-04T23:05:46.7234796Z == clock drift check ==
2019-12-04T23:05:46.7247774Z   local time: Wed Dec  4 23:05:46 UTC 2019
2019-12-04T23:05:46.9987044Z   network time: Wed, 04 Dec 2019 23:05:46 GMT
2019-12-04T23:05:46.9990903Z == end clock drift check ==
2019-12-04T23:05:49.7024682Z 
2019-12-04T23:05:49.7117817Z ##[error]Bash exited with code '1'.
2019-12-04T23:05:49.7158425Z ##[section]Starting: Checkout rust-lang/rust@auto to s
2019-12-04T23:05:49.7160267Z ==============================================================================
2019-12-04T23:05:49.7160349Z Task         : Get sources
2019-12-04T23:05:49.7160439Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bors · 2019-12-04T23:07:08Z

💔 Test failed - checks-azure

The wasm targets don't support gdb anyway so there's no need for this section there.

alexcrichton · 2019-12-05T04:15:33Z

@bors: r=eddyb

bors · 2019-12-05T04:15:34Z

📌 Commit 5ce09bc has been approved by eddyb

bors · 2019-12-05T05:28:55Z

⌛ Testing commit 5ce09bc with merge d825e35...

Disable gdb pretty printer global section on wasm targets The wasm targets don't support gdb anyway so there's no need for this section there.

bors · 2019-12-05T08:43:02Z

☀️ Test successful - checks-azure
Approved by: eddyb
Pushing d825e35 to master...

rust-highfive assigned eddyb Nov 18, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 18, 2019

eddyb approved these changes Nov 18, 2019

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 18, 2019

JohnTitor mentioned this pull request Nov 19, 2019

Rollup of 13 pull requests #66542

Closed

Centril mentioned this pull request Nov 20, 2019

Rollup of 6 pull requests #66591

Closed

Centril mentioned this pull request Nov 21, 2019

Rollup of 6 pull requests #66601

Closed

Centril mentioned this pull request Nov 21, 2019

Rollup of 6 pull requests #66604

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 21, 2019

JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 29, 2019

eddyb removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 29, 2019

eddyb added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Nov 29, 2019

alexcrichton force-pushed the disable-gdb-wasm branch from eda67ba to b8eb6b7 Compare December 2, 2019 21:15

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 2, 2019

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 4, 2019

Disable gdb pretty printer global section on wasm targets

5ce09bc

The wasm targets don't support gdb anyway so there's no need for this section there.

alexcrichton force-pushed the disable-gdb-wasm branch from b8eb6b7 to 5ce09bc Compare December 5, 2019 04:15

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 5, 2019

bors added a commit that referenced this pull request Dec 5, 2019

Auto merge of #66520 - alexcrichton:disable-gdb-wasm, r=eddyb

d825e35

Disable gdb pretty printer global section on wasm targets The wasm targets don't support gdb anyway so there's no need for this section there.

bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 5, 2019

bors merged commit 5ce09bc into rust-lang:master Dec 5, 2019

alexcrichton deleted the disable-gdb-wasm branch January 14, 2020 18:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Disable gdb pretty printer global section on wasm targets #66520

Disable gdb pretty printer global section on wasm targets #66520

alexcrichton commented Nov 18, 2019

rust-highfive commented Nov 18, 2019

eddyb commented Nov 18, 2019

bors commented Nov 18, 2019

Centril commented Nov 21, 2019

JohnCSimon commented Nov 29, 2019

eddyb commented Nov 29, 2019

alexcrichton commented Dec 2, 2019

alexcrichton commented Dec 2, 2019

bors commented Dec 2, 2019

bors commented Dec 4, 2019

rust-highfive commented Dec 4, 2019

bors commented Dec 4, 2019

alexcrichton commented Dec 5, 2019

bors commented Dec 5, 2019

bors commented Dec 5, 2019

bors commented Dec 5, 2019

Disable gdb pretty printer global section on wasm targets #66520

Disable gdb pretty printer global section on wasm targets #66520

Conversation

alexcrichton commented Nov 18, 2019

rust-highfive commented Nov 18, 2019

eddyb commented Nov 18, 2019

bors commented Nov 18, 2019

Centril commented Nov 21, 2019

JohnCSimon commented Nov 29, 2019

eddyb commented Nov 29, 2019

alexcrichton commented Dec 2, 2019

alexcrichton commented Dec 2, 2019

bors commented Dec 2, 2019

bors commented Dec 4, 2019

rust-highfive commented Dec 4, 2019

bors commented Dec 4, 2019

alexcrichton commented Dec 5, 2019

bors commented Dec 5, 2019

bors commented Dec 5, 2019

bors commented Dec 5, 2019