Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corrected comment in E0478 #67168

Merged
merged 2 commits into from
Dec 11, 2019
Merged

corrected comment in E0478 #67168

merged 2 commits into from
Dec 11, 2019

Conversation

ryanswilson59
Copy link

I believe this fixes the issue that I opened, #67040, about E0478 being contradictory.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @davidtwco (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 9, 2019
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-12-09T02:20:21.3051152Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-12-09T02:20:21.3240025Z ##[command]git config gc.auto 0
2019-12-09T02:20:21.3326478Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-12-09T02:20:21.3394871Z ##[command]git config --get-all http.proxy
2019-12-09T02:20:21.3556323Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67168/merge:refs/remotes/pull/67168/merge
---
2019-12-09T02:26:19.9334826Z    Compiling serde_json v1.0.40
2019-12-09T02:26:21.6126511Z    Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
2019-12-09T02:26:32.3803100Z     Finished release [optimized] target(s) in 1m 25s
2019-12-09T02:26:32.3903853Z tidy check
2019-12-09T02:26:33.1316426Z tidy error: /checkout/src/librustc_error_codes/error_codes/E0478.md:24: line longer than 80 chars
2019-12-09T02:26:35.0773596Z some tidy checks failed
2019-12-09T02:26:35.0773676Z Found 485 error codes
2019-12-09T02:26:35.0773899Z Found 0 error codes with no tests
2019-12-09T02:26:35.0773976Z Done!
2019-12-09T02:26:35.0773976Z Done!
2019-12-09T02:26:35.0783597Z 
2019-12-09T02:26:35.0784468Z 
2019-12-09T02:26:35.0785354Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor"
2019-12-09T02:26:35.0785487Z 
2019-12-09T02:26:35.0785508Z 
2019-12-09T02:26:35.0837238Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-12-09T02:26:35.0837382Z Build completed unsuccessfully in 0:01:28
2019-12-09T02:26:35.0837382Z Build completed unsuccessfully in 0:01:28
2019-12-09T02:26:35.0844223Z == clock drift check ==
2019-12-09T02:26:35.0857677Z   local time: Mon Dec  9 02:26:35 UTC 2019
2019-12-09T02:26:35.3663840Z   network time: Mon, 09 Dec 2019 02:26:35 GMT
2019-12-09T02:26:35.3664017Z == end clock drift check ==
2019-12-09T02:26:36.7879734Z 
2019-12-09T02:26:36.7962555Z ##[error]Bash exited with code '1'.
2019-12-09T02:26:36.7990179Z ##[section]Starting: Checkout
2019-12-09T02:26:36.7992325Z ==============================================================================
2019-12-09T02:26:36.7992392Z Task         : Get sources
2019-12-09T02:26:36.7992431Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Dylan-DPC-zz
Copy link

r? @Dylan-DPC

@Dylan-DPC-zz
Copy link

You need to adjust the line because it is exceeding the character limit (check the CI error)

@Dylan-DPC-zz
Copy link

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 10, 2019

📌 Commit 2183a94 has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 10, 2019
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Dec 10, 2019
corrected comment in E0478

I believe this fixes the issue that I opened,  rust-lang#67040, about E0478 being contradictory.
bors added a commit that referenced this pull request Dec 11, 2019
Rollup of 9 pull requests

Successful merges:

 - #66377 (Update RELEASES.md for 1.40.0)
 - #67134 (Ensure that we get a hard error on generic ZST constants if their bod…)
 - #67152 (Sort auto trait and blanket implementations display)
 - #67154 (Fix typos in src/libcore/alloc.rs docs)
 - #67168 (corrected comment in E0478)
 - #67178 (Move non clean impls items)
 - #67180 (doc: Use .copied() instead of .cloned() in Vec example)
 - #67181 (Update hashmap doc)
 - #67193 (In which we start tracking polonius in `-Z self-profile`)

Failed merges:

r? @ghost
@bors bors merged commit 2183a94 into rust-lang:master Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants