Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #67464

Merged
merged 15 commits into from
Dec 21, 2019
Merged

Rollup of 6 pull requests #67464

merged 15 commits into from
Dec 21, 2019

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Dec 20, 2019

Successful merges:

Failed merges:

r? @ghost

wesleywiser and others added 15 commits December 13, 2019 06:14
Co-Authored-By: matthewjasper <mjjasper1@gmail.com>
… r=oli-obk

Const prop should finish propagation into user defined variables

Fixes rust-lang#66638

~~Temporarily rebased on top of rust-lang#67015 to get those fixes.~~

r? @oli-obk
…imulacrum

Split up ptr/mod.rs in libcore...

...one with implementation detail for const ptr and the other with mut ptr

I am not sure if the "stable since 1.0.0" flags are the correct choice for the two additional mods.
Also, is it necessary for them to be "pub"? If so, there should be a good description for them.

Closes rust-lang#66891
…nikomatsakis

Don't suppress move errors for union fields

closes rust-lang#66500
Fix unresolved type span inside async object

Closes rust-lang#65180
r? @estebank
It's hard to create a minimal repro for that issue, [decided](https://rust-lang.zulipchat.com/#narrow/stream/187312-wg-async-foundations/topic/meeting.202019.2E12.2E17/near/183675659) to give up finding mcve.
cc [previous take](rust-lang#65668)
Separate region inference logic from error handling better

Split out from rust-lang#67241

r? @matthewjasper
…ewjasper

`is_binding_pat`: use explicit match & include or-pats in grammar

r? @matthewjasper @nikomatsakis
@Centril Centril added the rollup A PR which is a rollup label Dec 20, 2019
@Centril
Copy link
Contributor Author

Centril commented Dec 20, 2019

@bors r+ p=150 rollup=never

@bors
Copy link
Contributor

bors commented Dec 20, 2019

📌 Commit f465f95 has been approved by Centril

@bors
Copy link
Contributor

bors commented Dec 20, 2019

🌲 The tree is currently closed for pull requests below priority 100, this pull request will be tested once the tree is reopened

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Dec 20, 2019
@bors
Copy link
Contributor

bors commented Dec 21, 2019

⌛ Testing commit f465f95 with merge 9ff30a7...

bors added a commit that referenced this pull request Dec 21, 2019
Rollup of 6 pull requests

Successful merges:

 - #67130 (Const prop should finish propagation into user defined variables)
 - #67163 (Split up ptr/mod.rs in libcore...)
 - #67314 (Don't suppress move errors for union fields)
 - #67392 (Fix unresolved type span inside async object)
 - #67404 (Separate region inference logic from error handling better)
 - #67428 (`is_binding_pat`: use explicit match & include or-pats in grammar)

Failed merges:

r? @ghost
@bors
Copy link
Contributor

bors commented Dec 21, 2019

☀️ Test successful - checks-azure
Approved by: Centril
Pushing 9ff30a7 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 21, 2019
@bors bors merged commit f465f95 into rust-lang:master Dec 21, 2019
@Centril Centril deleted the rollup-j3mkl1m branch December 21, 2019 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants