Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 3 pull requests #67518

Closed
wants to merge 17 commits into from
Closed

Commits on Dec 21, 2019

  1. Configuration menu
    Copy the full SHA
    43888e8 View commit details
    Browse the repository at this point in the history
  2. add unreported error variant

    mark-i-m committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    94a9c62 View commit details
    Browse the repository at this point in the history
  3. tidy

    mark-i-m committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    3902e56 View commit details
    Browse the repository at this point in the history
  4. fix outlives suggestions

    mark-i-m committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    e5a1f48 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5d9e74e View commit details
    Browse the repository at this point in the history
  6. make regionerrors a typedef

    mark-i-m committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    e4379e6 View commit details
    Browse the repository at this point in the history
  7. Remove iter_private.rs

    The contents of this file have been moved in rust-lang#56932 (520e8b0) and the
    file should have been removed as well.
    qnighy committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    6903836 View commit details
    Browse the repository at this point in the history
  8. is_reported flag

    mark-i-m committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    5b06025 View commit details
    Browse the repository at this point in the history
  9. add comments

    mark-i-m committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    bd0ea19 View commit details
    Browse the repository at this point in the history
  10. use vec instead of smallvec

    mark-i-m committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    a155a9b View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    4f0dc7b View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    f5a8d1a View commit details
    Browse the repository at this point in the history
  13. convert hrtb error

    mark-i-m committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    d855782 View commit details
    Browse the repository at this point in the history
  14. minor updates to comments

    mark-i-m committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    1d9c561 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2019

  1. Rollup merge of rust-lang#67241 - mark-i-m:simplify-borrow_check-3, r…

    …=matthewjasper
    
    Refactorings to borrowck region diagnostic reporting
    
    This PR is a followup to rust-lang#66886 and rust-lang#67404
    
    EDIT: updated
    
    In this PR:  Clean up how errors are collected from NLL: introduce `borrow_check::diagnostics::RegionErrors` to collect errors. This is later passed to `MirBorrowckCtx::report_region_errors` after the `MirBorrowckCtx` is created. This will allow us to refactor away some of the extra context structs floating around (but we don't do it in this PR).  `borrow_check::region_infer` is now mostly free of diagnostic generating code. The signatures of most of the functions in `region_infer` lose somewhere between 4 and 7 arguments :)
    
    Left for future (feedback appreciated):
    
    - Merge `ErrorRegionCtx` with `MirBorrowckCtx`, as suggested by @matthewjasper in rust-lang#66886 (comment)
    - Maybe move the contents of `borrow_check::nll` into `borrow_check` and remove the `nll` submodule altogether.
    - Find a way to make `borrow_check::diagnostics::region_errors` less of a strange appendage to `RegionInferenceContext`. I'm not really sure how to do this yet. Ideas welcome.
    Centril authored Dec 22, 2019
    Configuration menu
    Copy the full SHA
    93fb9e6 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#67499 - Centril:mir-match-clean, r=matthewj…

    …asper
    
    Misc MIR building cleanups
    
    r? @matthewjasper
    Centril authored Dec 22, 2019
    Configuration menu
    Copy the full SHA
    7e034c5 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#67506 - qnighy:remove-iter-private, r=Dylan…

    …-DPC
    
    Remove iter_private.rs
    
    The contents of this file have been moved in rust-lang#56932 (520e8b0) and the file should have been removed as well.
    Centril authored Dec 22, 2019
    Configuration menu
    Copy the full SHA
    8d3b36f View commit details
    Browse the repository at this point in the history