-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 3 pull requests #67518
Closed
Closed
Rollup of 3 pull requests #67518
Commits on Dec 21, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 43888e8 - Browse repository at this point
Copy the full SHA 43888e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 94a9c62 - Browse repository at this point
Copy the full SHA 94a9c62View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3902e56 - Browse repository at this point
Copy the full SHA 3902e56View commit details -
Configuration menu - View commit details
-
Copy full SHA for e5a1f48 - Browse repository at this point
Copy the full SHA e5a1f48View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d9e74e - Browse repository at this point
Copy the full SHA 5d9e74eView commit details -
Configuration menu - View commit details
-
Copy full SHA for e4379e6 - Browse repository at this point
Copy the full SHA e4379e6View commit details -
The contents of this file have been moved in rust-lang#56932 (520e8b0) and the file should have been removed as well.
Configuration menu - View commit details
-
Copy full SHA for 6903836 - Browse repository at this point
Copy the full SHA 6903836View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b06025 - Browse repository at this point
Copy the full SHA 5b06025View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd0ea19 - Browse repository at this point
Copy the full SHA bd0ea19View commit details -
Configuration menu - View commit details
-
Copy full SHA for a155a9b - Browse repository at this point
Copy the full SHA a155a9bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f0dc7b - Browse repository at this point
Copy the full SHA 4f0dc7bView commit details -
Configuration menu - View commit details
-
Copy full SHA for f5a8d1a - Browse repository at this point
Copy the full SHA f5a8d1aView commit details -
Configuration menu - View commit details
-
Copy full SHA for d855782 - Browse repository at this point
Copy the full SHA d855782View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d9c561 - Browse repository at this point
Copy the full SHA 1d9c561View commit details
Commits on Dec 22, 2019
-
Rollup merge of rust-lang#67241 - mark-i-m:simplify-borrow_check-3, r…
…=matthewjasper Refactorings to borrowck region diagnostic reporting This PR is a followup to rust-lang#66886 and rust-lang#67404 EDIT: updated In this PR: Clean up how errors are collected from NLL: introduce `borrow_check::diagnostics::RegionErrors` to collect errors. This is later passed to `MirBorrowckCtx::report_region_errors` after the `MirBorrowckCtx` is created. This will allow us to refactor away some of the extra context structs floating around (but we don't do it in this PR). `borrow_check::region_infer` is now mostly free of diagnostic generating code. The signatures of most of the functions in `region_infer` lose somewhere between 4 and 7 arguments :) Left for future (feedback appreciated): - Merge `ErrorRegionCtx` with `MirBorrowckCtx`, as suggested by @matthewjasper in rust-lang#66886 (comment) - Maybe move the contents of `borrow_check::nll` into `borrow_check` and remove the `nll` submodule altogether. - Find a way to make `borrow_check::diagnostics::region_errors` less of a strange appendage to `RegionInferenceContext`. I'm not really sure how to do this yet. Ideas welcome.
Configuration menu - View commit details
-
Copy full SHA for 93fb9e6 - Browse repository at this point
Copy the full SHA 93fb9e6View commit details -
Rollup merge of rust-lang#67499 - Centril:mir-match-clean, r=matthewj…
…asper Misc MIR building cleanups r? @matthewjasper
Configuration menu - View commit details
-
Copy full SHA for 7e034c5 - Browse repository at this point
Copy the full SHA 7e034c5View commit details -
Rollup merge of rust-lang#67506 - qnighy:remove-iter-private, r=Dylan…
…-DPC Remove iter_private.rs The contents of this file have been moved in rust-lang#56932 (520e8b0) and the file should have been removed as well.
Configuration menu - View commit details
-
Copy full SHA for 8d3b36f - Browse repository at this point
Copy the full SHA 8d3b36fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.