Use the chocolatey CDN directly to avoid the flaky API #67572

aidanhs · 2019-12-23T23:34:05Z

No description provided.

rust-highfive · 2019-12-23T23:34:16Z

(rust_highfive has picked a reviewer for you, use r? to override)

Mark-Simulacrum · 2019-12-23T23:42:40Z

src/ci/scripts/install-msys2.sh

-            && ciCommandAddPath "$(ciCheckoutPath)/msys2/usr/bin" && break
-    done
+    # Pre-followed the api/v2 URL to the CDN since the API can be a bit flakey
+    curl -sSL https://packages.chocolatey.org/msys2.20190524.0.0.20191030.nupkg > msys2.nupkg


Have we confirmed that the API and not the package endpoint is flaky? If we're going to pin to a specific version, maybe we should upload these files to S3 and be done with it?

Have we confirmed that the API and not the package endpoint is flaky?

Sort of: https://status.chocolatey.org/issues/2019-12-18-timeouts-when-searching-and-installing-packages/

The errors I've seen directly point at the API (#67568) and the headers from the CDN indicate it's backed by cloudfront which I figure should be reliable.

This makes it easier to bump versions as well.

Okay, great! That sounds like a good reason to prefer the packages endpoint for now, and we can always take the next step if it becomes necessary.

rust-highfive · 2019-12-23T23:56:34Z

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-12-23T23:36:10.3952570Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-12-23T23:36:10.4252289Z ##[command]git config gc.auto 0
2019-12-23T23:36:10.4339186Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-12-23T23:36:10.4341729Z ##[command]git config --get-all http.proxy
2019-12-23T23:36:11.3672750Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67572/merge:refs/remotes/pull/67572/merge
---
2019-12-23T23:42:52.5888572Z    Compiling serde_json v1.0.40
2019-12-23T23:42:54.4206177Z    Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
2019-12-23T23:43:06.1320811Z     Finished release [optimized] target(s) in 1m 32s
2019-12-23T23:43:06.1417949Z tidy check
2019-12-23T23:43:06.9319905Z tidy error: /checkout/src/ci/scripts/install-msys2.sh:17: line longer than 100 chars
2019-12-23T23:43:08.8893338Z Found 485 error codes
2019-12-23T23:43:08.8893514Z Found 0 error codes with no tests
2019-12-23T23:43:08.8893559Z Done!
2019-12-23T23:43:08.8893600Z some tidy checks failed
2019-12-23T23:43:08.8893600Z some tidy checks failed
2019-12-23T23:43:08.8898765Z 
2019-12-23T23:43:08.8899024Z 
2019-12-23T23:43:08.8900526Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor"
2019-12-23T23:43:08.8901141Z 
2019-12-23T23:43:08.8901281Z 
2019-12-23T23:43:08.8908783Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-12-23T23:43:08.8909132Z Build completed unsuccessfully in 0:01:44
2019-12-23T23:43:08.8909132Z Build completed unsuccessfully in 0:01:44
2019-12-23T23:43:08.8952572Z == clock drift check ==
2019-12-23T23:43:08.8974513Z   local time: Mon Dec 23 23:43:08 UTC 2019
2019-12-23T23:43:09.1777364Z   network time: Mon, 23 Dec 2019 23:43:09 GMT
2019-12-23T23:43:09.1786953Z == end clock drift check ==
2019-12-23T23:43:10.5745032Z 
2019-12-23T23:43:10.5848730Z ##[error]Bash exited with code '1'.
2019-12-23T23:43:10.5878539Z ##[section]Starting: Checkout
2019-12-23T23:43:10.5880397Z ==============================================================================
2019-12-23T23:43:10.5880451Z Task         : Get sources
2019-12-23T23:43:10.5880517Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Mark-Simulacrum · 2019-12-24T00:22:28Z

r=me with tidy fixed.

aidanhs · 2019-12-24T01:53:47Z

@bors r=Mark-Simulacrum p=1

bors · 2019-12-24T01:53:48Z

📌 Commit cefeb66 has been approved by Mark-Simulacrum

bors · 2019-12-24T01:53:49Z

🌲 The tree is currently closed for pull requests below priority 100, this pull request will be tested once the tree is reopened

…rk-Simulacrum Use the chocolatey CDN directly to avoid the flaky API

aidanhs · 2019-12-24T02:04:34Z

Just want to note one test scenario I did try out successfully: downloading the nupkgs, disconnecting from internet and doing the install (to make sure it wasn't trying to do any other API operations).

tesuji · 2019-12-24T03:38:14Z

src/ci/scripts/install-msys2.sh

-            && ciCommandAddPath "$(ciCheckoutPath)/msys2/usr/bin" && break
-    done
+    # Pre-followed the api/v2 URL to the CDN since the API can be a bit flakey
+    curl -sSL https://packages.chocolatey.org/msys2.20190524.0.0.20191030.nupkg > \


Suggested change

curl -sSL https://packages.chocolatey.org/msys2.20190524.0.0.20191030.nupkg > \

curl -sSL https://packages.chocolatey.org/msys2.20190524.0.0.20191030.nupkg -o msys2.nupkg

…rk-Simulacrum Use the chocolatey CDN directly to avoid the flaky API

@ghost

Rollup of 7 pull requests Successful merges: - #67337 (Ensure that evaluating or validating a constant never reads from a static) - #67543 (Add regression tests for fixed ICEs) - #67547 (Cleanup err codes) - #67551 (Add long error code explanation message for E0627) - #67561 (remove `description` from `Error` impls in docs) - #67569 (Clean up unsafety in char::encode_utf8) - #67572 (Use the chocolatey CDN directly to avoid the flaky API) Failed merges: r? @ghost

aidanhs · 2019-12-24T12:38:53Z

@bors treeclosed-

aidanhs · 2019-12-24T12:40:07Z

@bors treeclose-

rust-highfive assigned Mark-Simulacrum Dec 23, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 23, 2019

aidanhs force-pushed the aphs-choco-direct-cdn branch from c28d7f1 to 4b8a868 Compare December 23, 2019 23:35

aidanhs mentioned this pull request Dec 23, 2019

Chocolatey fails to download msys2 #67568

Closed

Mark-Simulacrum reviewed Dec 23, 2019

View reviewed changes

Use the chocolatey CDN directly to avoid the flaky API

cefeb66

aidanhs force-pushed the aphs-choco-direct-cdn branch from 4b8a868 to cefeb66 Compare December 24, 2019 00:59

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 24, 2019

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Dec 24, 2019

Rollup merge of rust-lang#67572 - aidanhs:aphs-choco-direct-cdn, r=Ma…

37f97de

…rk-Simulacrum Use the chocolatey CDN directly to avoid the flaky API

Mark-Simulacrum mentioned this pull request Dec 24, 2019

Rollup of 7 pull requests #67573

Closed

tesuji reviewed Dec 24, 2019

View reviewed changes

Centril added a commit to Centril/rust that referenced this pull request Dec 24, 2019

Rollup merge of rust-lang#67572 - aidanhs:aphs-choco-direct-cdn, r=Ma…

a76d67f

…rk-Simulacrum Use the chocolatey CDN directly to avoid the flaky API

Centril mentioned this pull request Dec 24, 2019

Rollup of 7 pull requests #67575

Merged

bors merged commit cefeb66 into rust-lang:master Dec 24, 2019

aidanhs deleted the aphs-choco-direct-cdn branch December 24, 2019 11:29

SimonSapin mentioned this pull request Dec 25, 2019

Regression in Servo: "internal compiler error: mutable allocation in constant" #67601

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use the chocolatey CDN directly to avoid the flaky API #67572

Use the chocolatey CDN directly to avoid the flaky API #67572

aidanhs commented Dec 23, 2019

rust-highfive commented Dec 23, 2019

Mark-Simulacrum Dec 23, 2019 •

edited

Loading

mati865 Dec 24, 2019

aidanhs Dec 24, 2019

Mark-Simulacrum Dec 24, 2019

rust-highfive commented Dec 23, 2019

Mark-Simulacrum commented Dec 24, 2019

aidanhs commented Dec 24, 2019

bors commented Dec 24, 2019

bors commented Dec 24, 2019

aidanhs commented Dec 24, 2019 •

edited

Loading

tesuji Dec 24, 2019

aidanhs commented Dec 24, 2019

aidanhs commented Dec 24, 2019

	curl -sSL https://packages.chocolatey.org/msys2.20190524.0.0.20191030.nupkg > \
	curl -sSL https://packages.chocolatey.org/msys2.20190524.0.0.20191030.nupkg -o msys2.nupkg

Use the chocolatey CDN directly to avoid the flaky API #67572

Use the chocolatey CDN directly to avoid the flaky API #67572

Conversation

aidanhs commented Dec 23, 2019

rust-highfive commented Dec 23, 2019

Mark-Simulacrum Dec 23, 2019 • edited Loading

Choose a reason for hiding this comment

mati865 Dec 24, 2019

Choose a reason for hiding this comment

aidanhs Dec 24, 2019

Choose a reason for hiding this comment

Mark-Simulacrum Dec 24, 2019

Choose a reason for hiding this comment

rust-highfive commented Dec 23, 2019

Mark-Simulacrum commented Dec 24, 2019

aidanhs commented Dec 24, 2019

bors commented Dec 24, 2019

bors commented Dec 24, 2019

aidanhs commented Dec 24, 2019 • edited Loading

tesuji Dec 24, 2019

Choose a reason for hiding this comment

aidanhs commented Dec 24, 2019

aidanhs commented Dec 24, 2019

Mark-Simulacrum Dec 23, 2019 •

edited

Loading

aidanhs commented Dec 24, 2019 •

edited

Loading