Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work around a resolve bug in const prop #67631

Merged
merged 4 commits into from
Dec 30, 2019
Merged

Work around a resolve bug in const prop #67631

merged 4 commits into from
Dec 30, 2019

Commits on Dec 27, 2019

  1. Fix Instance::resolve() incorrectly returning specialized instances 

    We only want to return specializations when `Reveal::All` is passed, not
when `Reveal::UserFacing` is. Resolving this fixes several issues with
the `ConstProp`, `SimplifyBranches`, and `Inline` MIR optimization
passes.

Fixes rust-lang#66901
    @wesleywiser
    wesleywiser committed Dec 27, 2019
    Configuration menu
    Copy the full SHA
    25a8b5d View commit details
    Browse the repository at this point in the history

  2. Work around a resolve bug in const prop

    @oli-obk
    oli-obk committed Dec 27, 2019
    Configuration menu
    Copy the full SHA
    3eb0585 View commit details
    Browse the repository at this point in the history

  3. Prevent polymorphic const prop on assignments

    @oli-obk
    oli-obk committed Dec 27, 2019
    Configuration menu
    Copy the full SHA
    b3abebd View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2019

  1. Ensure that we don't cause *new* hard errors if we suddenly can evalu… 

    …ate more constants during const prop
    @oli-obk
    oli-obk committed Dec 28, 2019
    Configuration menu
    Copy the full SHA
    5fd8abd View commit details
    Browse the repository at this point in the history