-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 6 pull requests #67917
Rollup of 6 pull requests #67917
Commits on Jan 4, 2020
-
Configuration menu - View commit details
-
Copy full SHA for c09dac1 - Browse repository at this point
Copy the full SHA c09dac1View commit details -
Configuration menu - View commit details
-
Copy full SHA for eb36688 - Browse repository at this point
Copy the full SHA eb36688View commit details -
Configuration menu - View commit details
-
Copy full SHA for f744ea0 - Browse repository at this point
Copy the full SHA f744ea0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 358b898 - Browse repository at this point
Copy the full SHA 358b898View commit details
Commits on Jan 5, 2020
-
Configuration menu - View commit details
-
Copy full SHA for e03d1c4 - Browse repository at this point
Copy the full SHA e03d1c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d857ef - Browse repository at this point
Copy the full SHA 3d857efView commit details -
Fix ICE involving calling
Instance.ty
during const evaluationFixes rust-lang#67639 `Instance.ty` assumes that we are in a fully monomorphic context (e.g. codegen), and can therefore use an empty `ParamEnv` when performing normalization. Howver, the MIR constant evaluator code ends up calling `Instance.ty` as a result of us attemptign to 'speculatively' const-evaluate generic functions during const propagation. As a result, we may end up with projections involving type parameters (e.g. <T as MyTrait>::Bar>) in the type we are trying to normalize. Normalization expects us to have proper predicates in the `ParamEnv` for such projections, and will ICE if we don't. This commit adds a new method `Instance.ty_env`, which takes a `ParamEnv` for use during normalization. The MIR const-evaluator code is changed to use this method, passing in the proper `ParamEnv` for the context at hand.
Configuration menu - View commit details
-
Copy full SHA for ee922d4 - Browse repository at this point
Copy the full SHA ee922d4View commit details -
Co-Authored-By: Wesley Wiser <wwiser@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d41f9dd - Browse repository at this point
Copy the full SHA d41f9ddView commit details -
Configuration menu - View commit details
-
Copy full SHA for 71d163b - Browse repository at this point
Copy the full SHA 71d163bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 464b58c - Browse repository at this point
Copy the full SHA 464b58cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 33caf0b - Browse repository at this point
Copy the full SHA 33caf0bView commit details -
Configuration menu - View commit details
-
Copy full SHA for db2c4f2 - Browse repository at this point
Copy the full SHA db2c4f2View commit details -
This error may be produced during intermediate failed attempts at evaluation of a generic const, which may nevertheless succeed later.
Configuration menu - View commit details
-
Copy full SHA for adb46fd - Browse repository at this point
Copy the full SHA adb46fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 336b902 - Browse repository at this point
Copy the full SHA 336b902View commit details
Commits on Jan 6, 2020
-
Configuration menu - View commit details
-
Copy full SHA for cb8c071 - Browse repository at this point
Copy the full SHA cb8c071View commit details -
Configuration menu - View commit details
-
Copy full SHA for c7dbf5a - Browse repository at this point
Copy the full SHA c7dbf5aView commit details -
Rollup merge of rust-lang#67800 - Aaron1011:fix/mir-generic-instance,…
… r=oli-obk Fix ICE involving calling `Instance.ty` during const evaluation Fixes rust-lang#67639 `Instance.ty` assumes that we are in a fully monomorphic context (e.g. codegen), and can therefore use an empty `ParamEnv` when performing normalization. Howver, the MIR constant evaluator code ends up calling `Instance.ty` as a result of us attemptign to 'speculatively' const-evaluate generic functions during const propagation. As a result, we may end up with projections involving type parameters (e.g. <T as MyTrait>::Bar>) in the type we are trying to normalize. Normalization expects us to have proper predicates in the `ParamEnv` for such projections, and will ICE if we don't. This commit adds a new method `Instance.ty_env`, which takes a `ParamEnv` for use during normalization. The MIR const-evaluator code is changed to use this method, passing in the proper `ParamEnv` for the context at hand.
Configuration menu - View commit details
-
Copy full SHA for 3692075 - Browse repository at this point
Copy the full SHA 3692075View commit details -
Rollup merge of rust-lang#67873 - Dylan-DPC:feature/change-remove-to-…
…partial, r=Amanieu change remove to have a PartialEq bound Addresses [comment](rust-lang#67727 (comment)). References rust-lang#40062 r? @Amanieu
Configuration menu - View commit details
-
Copy full SHA for 005d9d5 - Browse repository at this point
Copy the full SHA 005d9d5View commit details -
Rollup merge of rust-lang#67897 - pickfire:patch-1, r=Dylan-DPC
Use `as_deref()` to replace `as_ref().map(...)` Suggested by @lzutao
Configuration menu - View commit details
-
Copy full SHA for 2e965e9 - Browse repository at this point
Copy the full SHA 2e965e9View commit details -
Rollup merge of rust-lang#67906 - varkor:silence-toogeneric, r=nagisa
Silence `TooGeneric` error This error may be produced during intermediate failed attempts at evaluation of a generic const, which may nevertheless succeed later. Fixes rust-lang#66962. r? @eddyb
Configuration menu - View commit details
-
Copy full SHA for c79034e - Browse repository at this point
Copy the full SHA c79034eView commit details -
Rollup merge of rust-lang#67912 - LPardue:patch-1, r=Centril
macros: typo fix spotted while reviewing the todo!macro docs
Configuration menu - View commit details
-
Copy full SHA for 162154f - Browse repository at this point
Copy the full SHA 162154fView commit details -
Rollup merge of rust-lang#67915 - lzutao:Self, r=Centril
Use Self instead of $type r? @Dylan-DPC
Configuration menu - View commit details
-
Copy full SHA for 34716a3 - Browse repository at this point
Copy the full SHA 34716a3View commit details