Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak lifetime definition errors #68267

Merged
merged 6 commits into from
Jan 21, 2020
Merged

Tweak lifetime definition errors #68267

merged 6 commits into from
Jan 21, 2020

Commits on Jan 20, 2020

  1. When encountering an undefined named lifetime, point to where it can be 

    This doesn't mention that using an existing lifetime is possible, but
that would hopefully be clear as always being an option. The intention
of this is to teach newcomers what the lifetime syntax is.
    @estebank
    estebank committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    6ba0875 View commit details
    Browse the repository at this point in the history

  2. When encountering an expected named lifetime and none are present, su… 

    …ggest adding one
    @estebank
    estebank committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    78d3ea5 View commit details
    Browse the repository at this point in the history

  3. review comments

    @estebank
    estebank committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    2102723 View commit details
    Browse the repository at this point in the history

  4. review comments: use closures

    @estebank
    estebank committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    12ff4d0 View commit details
    Browse the repository at this point in the history

  5. Deal with stabilization of feature(slice_patterns)

    @estebank
    estebank committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    0a6b553 View commit details
    Browse the repository at this point in the history

  6. review comments

    @estebank
    estebank committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    03d7fed View commit details
    Browse the repository at this point in the history