Tweak obligation error output #68377

estebank · 2020-01-20T01:29:44Z

Point at arguments or output when fn obligations come from them, or ident when they don't
Point at Sized bound (fix Providing a trait object as a type parameter to a function causes nonsense error #47990)
When object unsafe trait uses itself in associated item suggest using Self (fix Suggest using Self in traits #66424, fix Non trait object safe return diagnostic needs improvement #33375, partially address Special errors for common trait object issues #38376, cc Error when passing a trait object as a generic type doesn't indicate what is the trait object #61525)
Point at reason in object unsafe trait with Self in supertraits or where-clause (cc Object safety error when using an associated type as a type parameter in the super-trait listing #40533, cc Tweak obligation error output #68377)
On implicit type parameter Sized obligations, suggest ?Sized (fix Confusing error message when passing trait object to generic function #57744, fix better error message when using dyn type #46683, fix Suggest ?Sized on generics where applicable #38936)

rust-highfive · 2020-01-20T01:29:49Z

r? @matthewjasper

(rust_highfive has picked a reviewer for you, use r? to override)

src/librustc_typeck/check/wfcheck.rs

estebank · 2020-01-28T18:09:49Z

ping

estebank · 2020-01-30T03:14:03Z

cc @rust-lang/wg-diagnostics just because I'm stoked about the result :D

src/librustc_typeck/check/wfcheck.rs

src/librustc/traits/object_safety.rs

src/test/ui/issues/issue-20692.stderr

src/test/ui/wf/wf-unsafe-trait-obj-match.stderr

oli-obk · 2020-01-30T14:09:12Z

The new spans are awesome!

src/librustc/traits/object_safety.rs

src/librustc_typeck/check/wfcheck.rs

estebank · 2020-01-31T19:05:16Z

@bors try @rust-timer queue

rust-timer · 2020-01-31T19:05:17Z

Awaiting bors try build completion

bors · 2020-01-31T19:05:27Z

⌛ Trying commit 532f7c2ff15169402902ddcca71fc13833c3fe99 with merge 5a6609e6dd45556e226d848cf5f6b92301748bd9...

bors · 2020-01-31T21:51:47Z

☀️ Try build successful - checks-azure
Build commit: 5a6609e6dd45556e226d848cf5f6b92301748bd9 (5a6609e6dd45556e226d848cf5f6b92301748bd9)

rust-timer · 2020-01-31T21:51:49Z

Queued 5a6609e6dd45556e226d848cf5f6b92301748bd9 with parent 5371ddf, future comparison URL.

rust-timer · 2020-02-01T01:45:59Z

Finished benchmarking try commit 5a6609e6dd45556e226d848cf5f6b92301748bd9, comparison URL.

…dent when they don't

… `Self`

Stemming from the thread at https://twitter.com/indygreg/status/1223279056398929920

…ured suggestions when possible

estebank · 2020-02-02T21:11:29Z

Sorry for this PR becoming so big 😬, it's just addressing a bunch of intimately related issues. Each commit builds on the previous one.

…`where`-clause

Address rust-lang#53081

oli-obk

Just a wording, then this lgtm

src/test/ui/associated-const/associated-const-in-trait.stderr

estebank · 2020-02-03T18:56:51Z

Just a wording, then this lgtm

Is that r=oli-obk? 😅

oli-obk · 2020-02-04T17:12:57Z

@bors r+

yes :D I'll communicate that more clearly next time

bors · 2020-02-04T17:12:59Z

📌 Commit 0e58411 has been approved by oli-obk

bors · 2020-02-04T17:18:02Z

⌛ Testing commit 0e58411 with merge 5b0caef...

Tweak obligation error output - Point at arguments or output when fn obligations come from them, or ident when they don't - Point at `Sized` bound (fix #47990) - When object unsafe trait uses itself in associated item suggest using `Self` (fix #66424, fix #33375, partially address #38376, cc #61525) - Point at reason in object unsafe trait with `Self` in supertraits or `where`-clause (cc #40533, cc #68377) - On implicit type parameter `Sized` obligations, suggest `?Sized` (fix #57744, fix #46683)

bors · 2020-02-04T20:30:45Z

☀️ Test successful - checks-azure
Approved by: oli-obk
Pushing 5b0caef to master...

rust-highfive assigned matthewjasper Jan 20, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 20, 2020

This comment has been minimized.

Sign in to view

estebank force-pushed the fn-obligations-spans branch from e651f86 to fbb2a90 Compare January 20, 2020 03:22

Centril reviewed Jan 20, 2020

View reviewed changes

src/librustc_typeck/check/wfcheck.rs Outdated Show resolved Hide resolved

Centril reviewed Jan 20, 2020

View reviewed changes

src/librustc_typeck/check/wfcheck.rs Outdated Show resolved Hide resolved

Centril reviewed Jan 20, 2020

View reviewed changes

src/librustc_typeck/check/wfcheck.rs Outdated Show resolved Hide resolved

estebank force-pushed the fn-obligations-spans branch from fbb2a90 to 288ffa9 Compare January 25, 2020 22:28

estebank force-pushed the fn-obligations-spans branch from ae5611c to de4b03d Compare January 30, 2020 03:12

oli-obk reviewed Jan 30, 2020

View reviewed changes

matthewjasper reviewed Jan 30, 2020

View reviewed changes

src/librustc/traits/object_safety.rs Outdated Show resolved Hide resolved

src/librustc/traits/object_safety.rs Outdated Show resolved Hide resolved

src/librustc_typeck/check/wfcheck.rs Outdated Show resolved Hide resolved

src/librustc_typeck/check/wfcheck.rs Outdated Show resolved Hide resolved

This was referenced Feb 1, 2020

Error when passing a trait object as a generic type doesn't indicate what is the trait object #61525

Closed

Special errors for common trait object issues #38376

Closed

This comment has been minimized.

Sign in to view

estebank force-pushed the fn-obligations-spans branch from a218555 to 009dc5f Compare February 2, 2020 10:32

This comment has been minimized.

Sign in to view

estebank added 3 commits February 2, 2020 11:52

Point at arguments or output when fn obligations come from them, or i…

fca5c64

…dent when they don't

Point at Sized bound

1c9242f

When object unsafe trait uses itself in associated item suggest using…

d72bcdb

… `Self`

estebank added 6 commits February 2, 2020 11:53

Wording changes to object unsafe trait errors

413bfa4

Stemming from the thread at https://twitter.com/indygreg/status/1223279056398929920

Use more appropriate spans on object unsafe traits and provide struct…

a52ec87

…ured suggestions when possible

add tests for structured suggestion

542130b

Suggest ?Sized on type parameters

cb6dfea

Remove duplicated code

d216b73

Account for ?Sized type parameter bounds

342db71

estebank force-pushed the fn-obligations-spans branch from 009dc5f to 342db71 Compare February 2, 2020 19:56

fix rebase

16d935e

estebank mentioned this pull request Feb 2, 2020

Object safety error when using an associated type as a type parameter in the super-trait listing #40533

Open

Point at reason in object unsafe trait with Self in supertraits or …

865216b

…`where`-clause

estebank force-pushed the fn-obligations-spans branch from 34990c8 to 865216b Compare February 2, 2020 21:46

Deal with spans showing std lib

b9c125a

Address rust-lang#53081

estebank mentioned this pull request Feb 2, 2020

Note where implicit Sized requirement comes from #27964

Closed

oli-obk approved these changes Feb 3, 2020

View reviewed changes

src/test/ui/associated-const/associated-const-in-trait.stderr Outdated Show resolved Hide resolved

Change wording for object unsafe because of assoc const

0e58411

estebank force-pushed the fn-obligations-spans branch from 5439b6e to 0e58411 Compare February 3, 2020 18:54

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 4, 2020

bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 4, 2020

bors mentioned this pull request Feb 4, 2020

Improve reporting errors and suggestions for trait bounds #67665

Merged

bors merged commit 0e58411 into rust-lang:master Feb 4, 2020

bors mentioned this pull request Feb 4, 2020

Tweak impl signature mismatch errors involving RegionKind::ReVar lifetimes #67460

Merged

estebank mentioned this pull request Feb 5, 2020

Suggest ?Sized on generics where applicable #38936

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tweak obligation error output #68377

Tweak obligation error output #68377

estebank commented Jan 20, 2020 •

edited

Loading

rust-highfive commented Jan 20, 2020

This comment has been minimized.

estebank commented Jan 28, 2020

estebank commented Jan 30, 2020

oli-obk commented Jan 30, 2020

estebank commented Jan 31, 2020

rust-timer commented Jan 31, 2020

bors commented Jan 31, 2020

bors commented Jan 31, 2020

rust-timer commented Jan 31, 2020

rust-timer commented Feb 1, 2020

This comment has been minimized.

This comment has been minimized.

estebank commented Feb 2, 2020

oli-obk left a comment

estebank commented Feb 3, 2020

oli-obk commented Feb 4, 2020

bors commented Feb 4, 2020

bors commented Feb 4, 2020

bors commented Feb 4, 2020

Tweak obligation error output #68377

Tweak obligation error output #68377

Conversation

estebank commented Jan 20, 2020 • edited Loading

rust-highfive commented Jan 20, 2020

This comment has been minimized.

estebank commented Jan 28, 2020

estebank commented Jan 30, 2020

oli-obk commented Jan 30, 2020

estebank commented Jan 31, 2020

rust-timer commented Jan 31, 2020

bors commented Jan 31, 2020

bors commented Jan 31, 2020

rust-timer commented Jan 31, 2020

rust-timer commented Feb 1, 2020

This comment has been minimized.

This comment has been minimized.

estebank commented Feb 2, 2020

oli-obk left a comment

Choose a reason for hiding this comment

estebank commented Feb 3, 2020

oli-obk commented Feb 4, 2020

bors commented Feb 4, 2020

bors commented Feb 4, 2020

bors commented Feb 4, 2020

estebank commented Jan 20, 2020 •

edited

Loading