Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 5 pull requests #69004

Merged
merged 16 commits into from
Feb 9, 2020
Merged

Rollup of 5 pull requests #69004

merged 16 commits into from
Feb 9, 2020

Commits on Feb 1, 2020

  1. Configuration menu
    Copy the full SHA
    847d5b4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fd22823 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2020

  1. Configuration menu
    Copy the full SHA
    b82f6c5 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2020

  1. Configuration menu
    Copy the full SHA
    73936ab View commit details
    Browse the repository at this point in the history
  2. add regression test

    basil-cow committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    ab6ea2b View commit details
    Browse the repository at this point in the history
  3. add hir printing

    basil-cow committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    bf82582 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2020

  1. Configuration menu
    Copy the full SHA
    66fd4e6 View commit details
    Browse the repository at this point in the history
  2. Use associated_items query in impl overlap check

    This reduces the number of `associated_item` queries done here.
    jonas-schievink committed Feb 8, 2020
    Configuration menu
    Copy the full SHA
    f416573 View commit details
    Browse the repository at this point in the history
  3. Add a fast path to inherent impl overlap check

    Quickly skip impls that do not define any items with the same name
    jonas-schievink committed Feb 8, 2020
    Configuration menu
    Copy the full SHA
    52f7711 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e0cb1ae View commit details
    Browse the repository at this point in the history
  5. Add missing import

    jonas-schievink committed Feb 8, 2020
    Configuration menu
    Copy the full SHA
    58a9284 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2020

  1. Rollup merge of #68738 - kennytm:derive-clone-eq-for-fromutf8error, r…

    …=sfackler
    
    Derive Clone + Eq for std::string::FromUtf8Error
    
    Implement `Clone` and `Eq` for `std::string::FromUtf8Error`.
    
    Both the inner `Vec<u8>` and `std::str::Utf8Error` are also `Clone + Eq`, so I don't see why we shouldn't derive them on `FromUtf8Error` as well.
    
    (impl are insta-stable, requiring FCP from T-libs.)
    jonas-schievink authored Feb 9, 2020
    Configuration menu
    Copy the full SHA
    0b50319 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of #68742 - tspiteri:string-as-mut, r=sfackler

    implement AsMut<str> for String
    
    Closes #68741.
    jonas-schievink authored Feb 9, 2020
    Configuration menu
    Copy the full SHA
    3516df3 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of #68881 - eddyb:always-preserve-dbg-vars, r=nagisa

    rustc_codegen_llvm: always set AlwaysPreserve on all debuginfo variables
    
    Making this depend on the optimization level appears to have been a copy-paste mistake (other LLVM functions called in this module also take a `bool` argument, but there it means something unrelated).
    Also see #8855 (comment).
    
    I don't believe we have any reason to let LLVM omit user variables from DWARF, and we were already setting this to `true` when LLVM *could* optimize them away, so this PR should have no effect anyway.
    
    r? @michaelwoerister or @nagisa cc @hanna-kruppe @nikomatsakis
    jonas-schievink authored Feb 9, 2020
    Configuration menu
    Copy the full SHA
    0e23d36 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of #68911 - jonas-schievink:inherent-overlap, r=petroche…

    …nkov
    
    Speed up the inherent impl overlap check
    
    This gives a ~7% improvement in compile times for the stm32f0(x2) crate.
    
    Also addresses @eddyb's comment in #68837 (comment).
    jonas-schievink authored Feb 9, 2020
    Configuration menu
    Copy the full SHA
    f6b8281 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of #68913 - Areredify:gat_pretty, r=cramertj

    Pretty-print generic params and where clauses on associated types
    
    closes #67509
    jonas-schievink authored Feb 9, 2020
    Configuration menu
    Copy the full SHA
    da00582 View commit details
    Browse the repository at this point in the history