Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't give invalid suggestion on desugared span. #69120

Merged
merged 1 commit into from
Mar 9, 2020
Merged

Don't give invalid suggestion on desugared span. #69120

merged 1 commit into from
Mar 9, 2020

Conversation

spunit262
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @matthewjasper (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 13, 2020
@matthewjasper
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Feb 15, 2020

📌 Commit 30d4f1b has been approved by matthewjasper

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 15, 2020
@bors
Copy link
Contributor

bors commented Feb 15, 2020

⌛ Testing commit 30d4f1b with merge 9e8aade...

bors added a commit that referenced this pull request Feb 15, 2020
@bors
Auto merge of #69120 - spunit262:invalid-sugar-suggest, r=matthewjasper
9e8aade 
Don't give invalid suggestion on desugared span.
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Feb 15, 2020
@Dylan-DPC
Rollup merge of rust-lang#69120 - spunit262:invalid-sugar-suggest, r=…
b44269c 
…matthewjasper

Don't give invalid suggestion on desugared span.
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Feb 15, 2020
Closed
@bors
Copy link
Contributor

bors commented Feb 15, 2020

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 15, 2020
@JohnTitor
Copy link
Member

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 16, 2020
@bors
Copy link
Contributor

bors commented Feb 16, 2020

⌛ Testing commit 30d4f1b with merge 202d6ed079df887da03798f057d0481becc23ad4...

@rust-highfive

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Feb 16, 2020

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 16, 2020
@JohnCSimon JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 2, 2020
@JohnCSimon
Copy link
Member

Ping from triage:
@spunit262 - can you please address the test failures? Thanks.

@spunit262
Copy link
Contributor Author

The cause of the failure is the CI issue that was causing almost all PR to fail about a while ago, and that was fixed in #69252.

I checked to make sure that there was no bit rot, so I don't think there's anything for me to do on my end.

@JohnTitor
Copy link
Member

I don't think it's related to #69252 but indeed the failure seems spurious.
@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 7, 2020
@Centril Centril mentioned this pull request Mar 8, 2020
Merged
bors added a commit that referenced this pull request Mar 8, 2020
@bors
Auto merge of #69833 - Centril:rollup-mh74yue, r=Centril
2cb0b85 
Rollup of 7 pull requests

Successful merges:

 - #69120 (Don't give invalid suggestion on desugared span.)
 - #69326 (mir-interpret: add method to read wide strings from Memory)
 - #69608 (Expose target libdir information via print command)
 - #69734 (Change DIBuilderCreateEnumerator signature to match LLVM 9)
 - #69800 (Compile address sanitizer test with debuginfo)
 - #69807 (Cleanup E0391 explanation)
 - #69820 (clean up E0392 explanation)

Failed merges:

r? @ghost
@bors bors merged commit 85241b5 into rust-lang:master Mar 9, 2020
@spunit262 spunit262 deleted the invalid-sugar-suggest branch March 9, 2020 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@matthewjasper matthewjasper

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@spunit262 @rust-highfive @matthewjasper @bors @JohnTitor @JohnCSimon