Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up unstable book #69561

Merged
merged 3 commits into from
Mar 8, 2020
Merged

Conversation

JohnTitor
Copy link
Member

@JohnTitor JohnTitor commented Feb 28, 2020

  • Tracking issue for 'checked_duration_since' feature #58402's feature was renamed to tidy_test_never_used_anywhere_else and it is now used for tidy only
  • read_initializer link is wrong and the doc should be auto-generated so removed
  • Add dummy doc for link_cfg
  • Stop generating compiler_builtins_lib doc in favor of b8ccc0f
  • Make rustc_attrs tracking issue "None"

@rust-highfive
Copy link
Collaborator

r? @steveklabnik

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 28, 2020
@Dylan-DPC-zz
Copy link

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 29, 2020

📌 Commit 27fdf7e049ce1776d59bb0a6819185819cf724eb has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 29, 2020
@JohnTitor
Copy link
Member Author

@Dylan-DPC Would you mind my addressing the remaining things above in this PR? (Sorry, I should have marked this PR as WIP.)

@JohnTitor
Copy link
Member Author

@bors r- ^--

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 29, 2020
@JohnTitor JohnTitor changed the title Clean up unstable book [WIP] Clean up unstable book Feb 29, 2020
@Dylan-DPC-zz
Copy link

You can also do draft prs which are more noticeable

@JohnTitor
Copy link
Member Author

Okay, the work is almost done.

@Centril rustc_attrs tracking issue still points to #29642. Could we create new one?

@Centril
Copy link
Contributor

Centril commented Feb 29, 2020

@JohnTitor rustc_attrs shouldn't have a tracking issue, it's only for internal use.

@JohnTitor
Copy link
Member Author

Ah, okay! Then tracking issue can be None?

@Centril
Copy link
Contributor

Centril commented Feb 29, 2020

Yes.

@JohnTitor JohnTitor changed the title [WIP] Clean up unstable book Clean up unstable book Feb 29, 2020
@JohnTitor JohnTitor added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 29, 2020
@JohnTitor
Copy link
Member Author

I think it's ready to review.

@JohnTitor
Copy link
Member Author

I think almost should be fine but I'm not sure about tidy things, perhaps @Mark-Simulacrum thoughts?

@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Mar 6, 2020

📌 Commit c55df37 has been approved by Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Mar 6, 2020

🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 6, 2020
Centril added a commit to Centril/rust that referenced this pull request Mar 8, 2020
…=Mark-Simulacrum

Clean up unstable book

- rust-lang#58402's feature was renamed to `tidy_test_never_used_anywhere_else` and it is now used for tidy only
- `read_initializer` link is wrong and the doc should be auto-generated so removed
- Add dummy doc for `link_cfg`
- Stop generating `compiler_builtins_lib` doc in favor of b8ccc0f
- Make `rustc_attrs` tracking issue "None"
bors added a commit that referenced this pull request Mar 8, 2020
Rollup of 8 pull requests

Successful merges:

 - #69422 (Remove use of `unwrap()` from save-analysis)
 - #69548 (Turn trailing tokens in `assert!()` into hard errors)
 - #69561 (Clean up unstable book)
 - #69599 (check_binding_alt_eq_ty: improve precision wrt. `if let`)
 - #69641 (Update books)
 - #69776 (Fix & test leak of some BTreeMap nodes on panic during `into_iter`)
 - #69805 (resolve: Modernize some naming)
 - #69810 (test(bindings_after_at): add dynamic drop tests for bindings_after_at)

Failed merges:

r? @ghost
@bors bors merged commit d4860fc into rust-lang:master Mar 8, 2020
@JohnTitor JohnTitor deleted the clean-up-unstable-book branch March 8, 2020 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants