Deriving changes #6988
Merged
Deriving changes #6988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are now only called in generic and can be private. This includes manually inlining/merging some that are called once.
lt and gt are implement directly in terms of the corresponding method on their elements, and le and ge are the negations of these.
bors
added a commit
that referenced
this pull request
Jun 7, 2013
Several minor changes: - The clean-up I mentioned in #6851 (moving functions from deriving/mod.rs to deriving/generic.rs) - Move `expand_generic_deriving` to a method - Reimplement `deriving(Ord)` with no dependence on `Eq`
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Apr 8, 2021
Fix hidden variant suggestion on single variant Fixes rust-lang#6984 changelog: Fix hidden variant suggestion on `match_wildcard_for_single_variants`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several minor changes:
expand_generic_derivingto a methodderiving(Ord)with no dependence onEq