Fix #7017, add test #7018
Merged
Fix #7017, add test #7018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
error: unresolved import: could not find Works for me, is the test environment somehow different, and not putting the definitions libstd/rc.rs in std::rc in module std like one would expect? |
|
@bill-myers |
We were just looking at the last because we were overwriting ret.
|
Ok, changed to extra and rebased, should work now. |
|
Sorry, forgot the std -> extra rename in the expected error, third attempt uploaded. |
bors
added a commit
that referenced
this pull request
Jun 9, 2013
Minimally fixes #7017, we were overwriting the result and thus ignoring attributes before the last. csearch::get_item_attrs and decoder::get_item_attrs should probably also be changed to each_item_attrs using the for protocol, but that's just a minor performance/style issue.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Apr 8, 2021
Don't trigger `same_item_push` if the vec is used in the loop body fixes rust-lang#6987 changelog: `same_item_push`: Don't trigger if the `vec` is used in the loop body
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimally fixes #7017, we were overwriting the result and thus ignoring attributes before the last.
csearch::get_item_attrs and decoder::get_item_attrs should probably also be changed to each_item_attrs using the for protocol, but that's just a minor performance/style issue.