Permit reordering LeafNode fields #70675
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regardless of the order of the fields in the LeafNode, it is still guaranteed to
be a prefix of the InternalNode as that is still repr(C). Removing the repr(C)
annotation on the leaf node may permit the compiler to reorder the fields in a
more optimal fashion.
I believe this was missed as removable in #70111; previously the NodeHeader
struct needed to match the LeafNode bit-for-bit but that struct is gone as of
that PR.