Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add illumos triple #71145

Merged
merged 2 commits into from
Apr 16, 2020
Merged

Add illumos triple #71145

merged 2 commits into from
Apr 16, 2020

Conversation

pfmooney
Copy link
Contributor

This fixes #55553 and adds support for illumos as a target_os on x86_64. In addition to the compile spec and libstd additions, several library dependencies have been bumped in order to permit working builds of cargo and rustup for the new target.

Work originally started by @jasonbking, with subsequent additions by @pfmooney and @jclulow.

@pfmooney
Copy link
Contributor Author

The cargo update in #71138 will supersede the need for one here, assuming it lands first.

Co-Authored-By: Jason King <jason.brian.king@gmail.com>
Co-Authored-By: Joshua M. Clulow <jmc@oxide.computer>
The ioctl(FIONBIO) method of setting a file descriptor to be
non-blocking does not notify the underlying resource in the same way
that fcntl(F_SETFL, O_NONBLOCK) does on illumos and Solaris.
@pfmooney
Copy link
Contributor Author

Rebased on top of #71138 and updated to include set_nonblocking() modification for Socket on illumos and Solaris.

@pfmooney
Copy link
Contributor Author

cc: @nagisa

@nagisa
Copy link
Member

nagisa commented Apr 15, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Apr 15, 2020

📌 Commit dda5c97 has been approved by nagisa

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 15, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 15, 2020
Add illumos triple

This fixes rust-lang#55553 and adds support for `illumos` as a `target_os` on `x86_64`.  In addition to the compile spec and libstd additions, several library dependencies have been bumped in order to permit working builds of cargo and rustup for the new target.

Work originally started by @jasonbking, with subsequent additions by @pfmooney and @jclulow.
This was referenced Apr 15, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 15, 2020
Rollup of 6 pull requests

Successful merges:

 - rust-lang#69903 (Do not ICE in the face of invalid enum discriminant)
 - rust-lang#70354 (Update RELEASES.md for 1.43.0)
 - rust-lang#70774 (End cleanup on rustdoc-js tools)
 - rust-lang#70990 (Improve rustdoc source code a bit)
 - rust-lang#71145 (Add illumos triple)
 - rust-lang#71166 (Clean up E0518 explanation)

Failed merges:

r? @ghost
@bors bors merged commit 905a920 into rust-lang:master Apr 16, 2020
pub fn set_nonblocking(&self, nonblocking: bool) -> io::Result<()> {
// FIONBIO is inadequate for sockets on illumos/Solaris, so use the
// fcntl(F_[GS]ETFL)-based method provided by FileDesc instead.
self.0.set_nonblocking(nonblocking)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This generally seems to be the portable and recommended method on POSIX. Makes me wonder why we do something else on Linux and other Unices.

ehuss added a commit to ehuss/rust-forge that referenced this pull request May 15, 2020
- aarch64-unknown-none: rust-lang/rust#68334
- aarch64-unknown-none-softfloat: rust-lang/rust#64589
- armv7-unknown-linux-gnueabi: rust-lang/rust#63107
- armv7-unknown-linux-musleabi: rust-lang/rust#63107
- aarch64-apple-tvos: rust-lang/rust#68191
- armv7a-none-eabihf: rust-lang/rust#68253
- i686-unknown-uefi: rust-lang/rust#64334
- thumbv7neon-unknown-linux-musleabihf: rust-lang/rust#66103
- x86_64-apple-ios-macabi: rust-lang/rust#63467
- x86_64-apple-tvos: rust-lang/rust#68191
- x86_64-linux-kernel: rust-lang/rust#64051
- x86_64-unknown-hermit-kernel: rust-lang/rust#66713
- x86_64-unknown-illumos: rust-lang/rust#71145

Moved to tier 2:
- aarch64-unknown-none: rust-lang/rust#68334
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a separate target for illumos
5 participants