Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused rustc_serialize::hex module #71236

Merged
merged 2 commits into from
Apr 22, 2020
Merged

Conversation

sinkuu
Copy link
Contributor

@sinkuu sinkuu commented Apr 17, 2020

  • Remove unused rustc_serialize::hex module
  • Cleanup Cargo.toml

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 17, 2020
@petrochenkov
Copy link
Contributor

Did you take the list of unused crates from #69203 by chance?

@sinkuu
Copy link
Contributor Author

sinkuu commented Apr 17, 2020

No, I just used a stupid script.

@bors
Copy link
Contributor

bors commented Apr 20, 2020

☔ The latest upstream changes (presumably #71007) made this pull request unmergeable. Please resolve the merge conflicts.

@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Apr 21, 2020

📌 Commit fae4e2a has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 21, 2020
@nikomatsakis
Copy link
Contributor

@bors rollup

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 21, 2020
Remove unused rustc_serialize::hex module

* Remove unused `rustc_serialize::hex` module
* Cleanup `Cargo.toml`
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 21, 2020
Remove unused rustc_serialize::hex module

* Remove unused `rustc_serialize::hex` module
* Cleanup `Cargo.toml`
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 22, 2020
Rollup of 7 pull requests

Successful merges:

 - rust-lang#70998 (Suggest `-> impl Trait` and `-> Box<dyn Trait>` on fn that doesn't return)
 - rust-lang#71236 (Remove unused rustc_serialize::hex module)
 - rust-lang#71366 (Use assoc int consts3)
 - rust-lang#71372 (Fix #! (shebang) stripping account space issue)
 - rust-lang#71384 (Fix stage0.txt version number comment)
 - rust-lang#71390 (Fix incorrect description of E0690)
 - rust-lang#71399 (Clean up E0554 explanation)

Failed merges:

r? @ghost
@bors
Copy link
Contributor

bors commented Apr 22, 2020

☔ The latest upstream changes (presumably #71410) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 22, 2020
@bors bors merged commit 567e54f into rust-lang:master Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants