Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prefix should not be mutable. #71525

Merged
merged 1 commit into from
May 14, 2020
Merged

prefix should not be mutable. #71525

merged 1 commit into from
May 14, 2020

Conversation

ldm0
Copy link
Contributor

@ldm0 ldm0 commented Apr 24, 2020

Change the process from for loop to find, which makes the prefix able to be immutable.

@rust-highfive
Copy link
Collaborator

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 24, 2020
@ldm0 ldm0 changed the title Minor fix prefix should not be mutable. Apr 24, 2020
@joelpalmer joelpalmer added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 5, 2020
@Mark-Simulacrum
Copy link
Member

r? @Mark-Simulacrum

@bors r+

Thanks! Seems like a reasonable cleanup.

@bors
Copy link
Contributor

bors commented May 11, 2020

📌 Commit 079817d has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 11, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request May 12, 2020
`prefix` should not be mutable.

Change the process from for loop to find, which makes the `prefix` able to be immutable.
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request May 13, 2020
`prefix` should not be mutable.

Change the process from for loop to find, which makes the `prefix` able to be immutable.
@bors
Copy link
Contributor

bors commented May 14, 2020

⌛ Testing commit 079817d with merge fbda1a3b113af16166ee281266afb75cffcce447...

@RalfJung
Copy link
Member

@bors retry
yielding to rollup containing this PR

bors added a commit to rust-lang-ci/rust that referenced this pull request May 14, 2020
Rollup of 12 pull requests

Successful merges:

 - rust-lang#71525 (`prefix` should not be mutable.)
 - rust-lang#71741 (Pointer printing: do not print 0 offset)
 - rust-lang#71870 (Be slightly more precise about any::type_name()'s guarantees.)
 - rust-lang#71909 (Document From trait for Option implementations)
 - rust-lang#71964 (Fix bootstrap failing on win32)
 - rust-lang#72137 (Clean up E0581 explanation)
 - rust-lang#72138 (Add doc comment for `rustc_middle::mir::mono::Linkage`)
 - rust-lang#72150 (Remove UnnormalizedProjection)
 - rust-lang#72151 (Update books)
 - rust-lang#72163 (docs: remove comment referencing non-existent method)
 - rust-lang#72169 (Clean up E0582 explanation)
 - rust-lang#72183 (Fix Arc::decr_strong_count doc test)

Failed merges:

r? @ghost
@bors bors merged commit 32ea6a1 into rust-lang:master May 14, 2020
@ldm0 ldm0 deleted the intosug branch May 14, 2020 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants