Add core::future::IntoFuture #72459
Merged
Add core::future::IntoFuture #72459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
yoshuawuyts
commented
May 22, 2020
src/libstd/future.rs
Outdated
Comment on lines
3
to
17
| #[doc(inline)] | ||
| #[stable(feature = "futures_api", since = "1.36.0")] | ||
| pub use core::future::*; | ||
| pub use core::future::Future; | ||
|
|
||
| #[doc(inline)] | ||
| #[unstable(feature = "gen_future", issue = "50547")] | ||
| pub use core::future::{from_generator, get_context, ResumeTy}; | ||
|
|
||
| #[doc(inline)] | ||
| #[unstable(feature = "future_readiness_fns", issue = "70921")] | ||
| pub use core::future::{ready, Ready, pending, Pending}; | ||
|
|
||
| #[doc(inline)] | ||
| #[unstable(feature = "into_future", issue = "67644")] | ||
| pub use core::future::IntoFuture; |
There was a problem hiding this comment.
CI was failing because the core::future::* export was exporting more than it promised. This splits up the catch-all export into individual exports and correctly marks their stability guarantees.
This patch adds `core::future::IntoFuture`. However unlike earlier PRs this patch does not integrate it into the `async/.await` lowering. That integration should be done in a follow-up PR.
|
r? @tmandry |
|
@bors r+ rollup On the original PRs we already decided that we approve the concept, so I see no reason not to add unstable traits. |
|
📌 Commit 9ff5020 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 23, 2020
Rollup of 7 pull requests Successful merges: - rust-lang#71289 (Allow using `Self::` in doc) - rust-lang#72375 (Improve E0599 explanation) - rust-lang#72385 (Add some teams to prioritization exclude_labels) - rust-lang#72395 (Allow rust-highfive to label issues it creates.) - rust-lang#72453 (Add flag to open docs: x.py doc --open) - rust-lang#72459 (Add core::future::IntoFuture) - rust-lang#72461 (Clean up E0600 explanation) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch reintroduces the
core::future::IntoFuturetrait. However unlike earlier PRs this patch does not integrate it into theasync/.awaitlowering since that lead to performance regressions. By introducing the trait separately from the integration, the integration PR can be more narrowly scoped, and people can start trying out theIntoFuturetrait today. Thanks heaps!cc/ @rust-lang/wg-async-foundations
References
IntoFutureadd IntoFuture trait and support for await #65244IntoFuture(assigned to me) Re-land "add IntoFuture trait and support for await" #67982IntoFutureTracking issue forIntoFuture#67644