Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Spans from HIR -- 3/N -- hir::Item #73095

Closed
wants to merge 33 commits into from
Closed

Remove Spans from HIR -- 3/N -- hir::Item #73095

wants to merge 33 commits into from

Conversation

cjgillot
Copy link
Contributor

@cjgillot cjgillot commented Jun 7, 2020

Third step in rust-lang/compiler-team#294
Builds on #73094
Split out of #72015

This PR removes the span from hir::Item.

@rust-highfive
Copy link
Collaborator

r? @ecstatic-morse

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 7, 2020
@cjgillot cjgillot changed the title Remove Spans from HIR -- 2/N -- hir::Item Remove Spans from HIR -- 3/N -- hir::Item Jun 7, 2020
@cjgillot
Copy link
Contributor Author

cjgillot commented Jun 7, 2020

r? @ghost , sorry

@ecstatic-morse ecstatic-morse removed their assignment Jun 7, 2020
@bors
Copy link
Contributor

bors commented Jun 10, 2020

☔ The latest upstream changes (presumably #72972) made this pull request unmergeable. Please resolve the merge conflicts.

@cjgillot
Remove useless Clone bound in IndexVec.
3603d31
@cjgillot
Introduce HirIdVec.
76a36df
@cjgillot
Collect spans during HIR indexing.
c6acd0f
@cjgillot
Introduce a query for HIR spans.
71b5666
@cjgillot
Collect spans during lowering.
5b5bc8d
@cjgillot
Collect spans directly into an IndexVec.
6a1537c
@cjgillot
Directly use span map for indexing.
3640fb3
@cjgillot
Don't pass spans in hir::map::blocks.
1b9ccbf
@cjgillot
Add comment.
9f00730
@cjgillot
Stop passing the Span in HIR visiting.
ff32863
@cjgillot
Pass HirId in save_analysis.
61402a5
@cjgillot
Remove span from hir::Param.
a1b12d8
@cjgillot
Remove span from hir::Variant.
dad5ec0
@cjgillot
Remove span from hir::StructField.
0bf0ea2
@cjgillot
Remove span from hir::Stmt.
76f16ed
@cjgillot
Remove span from hir::Block.
8197821
@cjgillot
Remove span from hir::MacroDef.
deec340
@cjgillot
Remove span from hir::GenericParam.
7584102
@cjgillot
Remove span from hir::Arm.
71c2c92
@cjgillot
Remove span from hir::FieldPat.
f94dac7
@cjgillot
Remove span from hir::Local.
1f05c3d
@cjgillot
Remove span from hir::Pat.
61504ae
@Muirrum
Copy link
Member

Muirrum commented Jul 17, 2020

@rustbot modify labels to: +S-waiting-on-author -S-waiting-on-review

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 17, 2020
@Dylan-DPC-zz
Copy link

closing this due to inactivity. Has a number of conflicts

@Dylan-DPC-zz Dylan-DPC-zz added S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cjgillot @rust-highfive @bors @Muirrum @Dylan-DPC-zz @ecstatic-morse @rustbot