Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert PR #72389 - "Explain move errors that occur due to method calls involving self" #73594

Merged
merged 3 commits into from
Jun 23, 2020
Merged

Revert PR #72389 - "Explain move errors that occur due to method calls involving self" #73594

merged 3 commits into from
Jun 23, 2020

Commits on Jun 22, 2020

  1. Revert "Rollup merge of rust-lang#72389 - Aaron1011:feature/move-fn-s… 

    …elf-msg, r=nikomatsakis"

This reverts commit 372cb9b, reversing
changes made to 5c61a8d.
    @Aaron1011
    Aaron1011 committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    ad9972a View commit details
    Browse the repository at this point in the history

  2. Re-enable Clippy tests

    @Aaron1011
    Aaron1011 committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    d3feb8b View commit details
    Browse the repository at this point in the history

  3. Stop using old version of syn in rustc-workspace-hack 

    None of the tools seem to need syn 0.15.35, so we can just build syn
1.0.

This was causing an issue with clippy's `compile-test` program: since
multiple versions of `syn` would exist in the build directory, we would
non-deterministically pick one based on filesystem iteration order. If
the pre-1.0 version of `syn` was picked, a strange build error would
occur (see
rust-lang#73594 (comment))

To prevent this kind of issue from happening again, we now panic if we
find multiple versions of a crate in the build directly, instead of
silently picking the first version we find.
    @Aaron1011
    Aaron1011 committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    e2ab98d View commit details
    Browse the repository at this point in the history