Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement feature(const_generics_defaults) #75384

Merged
merged 8 commits into from
Mar 24, 2021
Merged

implement feature(const_generics_defaults) #75384

merged 8 commits into from
Mar 24, 2021
+517 −191

Commits on Mar 23, 2021

  1. Add has_default to GenericParamDefKind::Const 

    This currently creates a field which is always false on GenericParamDefKind for future use when
consts are permitted to have defaults

Update const_generics:default locations

Previously just ignored them, now actually do something about them.

Fix using type check instead of value

Add parsing

This adds all the necessary changes to lower const-generics defaults from parsing.

Change P<Expr> to AnonConst

This matches the arguments passed to instantiations of const generics, and makes it specific to
just anonymous constants.

Attempt to fix lowering bugs
    @JulianKnodt
    JulianKnodt committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    e4e5db4 View commit details
    Browse the repository at this point in the history

  2. Some refactoring

    @varkor @JulianKnodt
    varkor authored and JulianKnodt committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    8ef8138 View commit details
    Browse the repository at this point in the history

  3. progress, stuff compiles now

    @lcnr @JulianKnodt
    lcnr authored and JulianKnodt committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    b0feb5b View commit details
    Browse the repository at this point in the history

  4. Update tests

    @JulianKnodt
    JulianKnodt committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    0e56a08 View commit details
    Browse the repository at this point in the history

  5. Add query for const_param_default

    @JulianKnodt
    JulianKnodt committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    9fe793a View commit details
    Browse the repository at this point in the history

  6. Update with comments 

    A bunch of nits fixed, and a new test for pretty printing the AST.
    @JulianKnodt
    JulianKnodt committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    ea2af70 View commit details
    Browse the repository at this point in the history

  7. Update with comments

    @JulianKnodt
    JulianKnodt committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    7116bb5 View commit details
    Browse the repository at this point in the history

  8. Update to not have extra match

    @JulianKnodt
    JulianKnodt committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    33370fd View commit details
    Browse the repository at this point in the history