Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename IsJoint -> Spacing #76291

Merged
merged 2 commits into from
Sep 10, 2020
Merged

Rename IsJoint -> Spacing #76291

merged 2 commits into from
Sep 10, 2020

Conversation

matklad
Copy link
Member

@matklad matklad commented Sep 3, 2020

Builds on #76286 and might conflict with #76285

r? @petrochenkov

@matklad matklad added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. labels Sep 3, 2020
To match better naming from proc-macro
@matklad matklad changed the title Spacing Rename IsJoint -> Spacing Sep 3, 2020
@jyn514 jyn514 added the A-parser Area: The parsing of Rust source code to an AST label Sep 3, 2020
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Sep 3, 2020

📌 Commit ccf41dd has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 3, 2020
matklad added a commit to matklad/rust that referenced this pull request Sep 4, 2020
matklad added a commit to matklad/rust that referenced this pull request Sep 4, 2020
matklad added a commit to matklad/rust that referenced this pull request Sep 4, 2020
matklad added a commit to matklad/rust that referenced this pull request Sep 4, 2020
matklad added a commit to matklad/rust that referenced this pull request Sep 4, 2020
@bors
Copy link
Contributor

bors commented Sep 5, 2020

☔ The latest upstream changes (presumably #76376) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 5, 2020
@bors
Copy link
Contributor

bors commented Sep 10, 2020

⌛ Testing commit ccf41dd with merge a18b34d...

@bors
Copy link
Contributor

bors commented Sep 10, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: petrochenkov
Pushing a18b34d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 10, 2020
@bors bors merged commit a18b34d into rust-lang:master Sep 10, 2020
@rustbot rustbot added this to the 1.48.0 milestone Sep 10, 2020
@95th
Copy link
Contributor

95th commented Sep 10, 2020

This helps so much in the readability. Thanks

@matklad matklad deleted the spacing branch September 24, 2020 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-parser Area: The parsing of Rust source code to an AST merged-by-bors This PR was explicitly merged by bors. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants