Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 12 pull requests #76652

Closed
wants to merge 36 commits into from

Commits on Sep 4, 2020

  1. NRVO: Allow occurrences of the return place in var debug info

    The non-use occurrence of the return place in var debug info does not
    currently inhibit NRVO optimization, but it will fail assertion in
    `visit_place` when optimization is performed.
    
    Relax assertion check to allow the return place in var debug info.
    
    This case might be impossible to hit in optimization pipelines as of
    now, but can be encountered in customized mir-opt-level=2 pipeline with
    copy propagation disabled. For example in:
    
    ```
    pub fn b(s: String) -> String {
        a(s)
    }
    
    #[inline]
    pub fn a(s: String) -> String {
        let x = s;
        let y = x;
        y
    }
    ```
    tmiasko committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    0151061 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2020

  1. Ignore | and + tokens during proc-macro pretty-print check

    Fixes rust-lang#76182
    
    This is an alternative to PR rust-lang#76188
    
    These tokens are not preserved in the AST in certain cases
    (e.g. a leading `|` in a pattern or a trailing `+` in a trait bound).
    
    This PR ignores them entirely during the pretty-print/reparse check
    to avoid spuriously using the re-parsed tokenstream.
    Aaron1011 committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    283d4c4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    15aa6f3 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2020

  1. Add ui test for 74672 and 76571

    These tests will fall without the next commit.
    tesuji committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    fb8d070 View commit details
    Browse the repository at this point in the history
  2. Ignore rustc_private items from std docs

    Apply suggestions from code review
    
    Co-authored-by: Joshua Nelson <joshua@yottadb.com>
    tesuji and Joshua Nelson committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    c3d048a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    439b766 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f9059a4 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    62068a5 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    56f5c7f View commit details
    Browse the repository at this point in the history
  7. just max_level_info

    guswynn committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    0be66d7 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2020

  1. Configuration menu
    Copy the full SHA
    9500067 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0439556 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4284aad View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b1e481d View commit details
    Browse the repository at this point in the history
  5. Make all methods of Duration const

    Make the following methods of `Duration` unstable const under `duration_const_2`:
     - `from_secs_f64`
     - `from_secs_f32`
     - `mul_f64`
     - `mul_f32`
     - `div_f64`
     - `div_f32`
    
    This results in all methods of `Duration` being (unstable) const.
    
    Also adds tests for these methods in a const context, moved the test to `library` as part of rust-lang#76268.
    
    Possible because of rust-lang#72449, which made the relevant `f32` and `f64` methods const.
    
    Tracking issue: rust-lang#72440
    CDirkx committed Sep 12, 2020
    Configuration menu
    Copy the full SHA
    73e0a56 View commit details
    Browse the repository at this point in the history
  6. Add mailmap entry

    CDirkx committed Sep 12, 2020
    Configuration menu
    Copy the full SHA
    869021e View commit details
    Browse the repository at this point in the history
  7. Fix const-display.rs XPATH queries (rust-lang#1)

    * Fix `const-display.rs` XPATH queries
    
    * Add `issue_76501.rs` test file
    
    * Rename issue_76501.rs to issue-76501.rs
    slightlyoutofphase authored Sep 12, 2020
    Configuration menu
    Copy the full SHA
    9c13894 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    8a1288b View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    4f0047e View commit details
    Browse the repository at this point in the history
  10. Fix a typo

    nox committed Sep 12, 2020
    Configuration menu
    Copy the full SHA
    75f0f7a View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    caf6c92 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    a7b092f View commit details
    Browse the repository at this point in the history
  13. Set link-shared if LLVM ThinLTO is enabled in config.rs

    This avoids missing a shared build when uplifting LLVM artifacts into the
    sysroot. We were already producing a shared link anyway, though, so this is not
    a visible change from the end user's perspective.
    Mark-Simulacrum committed Sep 12, 2020
    Configuration menu
    Copy the full SHA
    2e87a6e View commit details
    Browse the repository at this point in the history
  14. Remove Windows details from Unix and VmWorks symlink() docstrings

    This note is not relevant to other operating systems.
    nicholasbishop committed Sep 12, 2020
    Configuration menu
    Copy the full SHA
    2eeb8f1 View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#76306 - tmiasko:nrvo-debuginfo, r=ecstatic-…

    …morse
    
    NRVO: Allow occurrences of the return place in var debug info
    
    The non-use occurrence of the return place in var debug info does not
    currently inhibit NRVO optimization, but it will fail assertion in
    `visit_place` when optimization is performed.
    
    Relax assertion check to allow the return place in var debug info.
    
    This case might be impossible to hit in optimization pipelines as of
    now, but can be encountered in customized mir-opt-level=2 pipeline with
    copy propagation disabled. For example in:
    
    ```rust
    pub fn b(s: String) -> String {
        a(s)
    }
    
    #[inline]
    pub fn a(s: String) -> String {
        let x = s;
        let y = x;
        y
    }
    ```
    Dylan-DPC authored Sep 12, 2020
    Configuration menu
    Copy the full SHA
    365e79c View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#76335 - CDirkx:const-duration, r=ecstatic-m…

    …orse
    
    Make all methods of `Duration` unstably const
    
    Make the following methods of `Duration` unstable const under `duration_const_2`:
     - `from_secs_f64`
     - `from_secs_f32`
     - `mul_f64`
     - `mul_f32`
     - `div_f64`
     - `div_f32`
    
    This results in all methods of `Duration` being (unstable) const.
    
    Moved the tests to `library` as part of rust-lang#76268.
    
    Possible because of rust-lang#72449, which made the relevant `f32` and `f64` methods const.
    
    Tracking issue: rust-lang#72440
    
    r? @ecstatic-morse
    Dylan-DPC authored Sep 12, 2020
    Configuration menu
    Copy the full SHA
    d674504 View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#76349 - Mark-Simulacrum:dl-llvm, r=alexcric…

    …hton
    
    Download LLVM from CI to bootstrap (linux-only to start)
    
    This follows rust-lang#76332, adding support for using CI-built LLVM rather than building it locally. This should essentially "just work," but is left off by default in this PR.
    
    While we can support downloading LLVM for multiple host triples, this currently only downloads it for the build triple. That said, it should be possible to expand this relatively easily should multiple host triples be desired. Most people shouldn't be adjusting host/target triples though, so this should cover most use cases.
    
    Currently this downloads LLVM for the last bors-authored commit in the `git log`. This is a bit suboptimal -- we want the last bors-authored commit that touched the llvm-project submodule in basically all cases. But for now this just adds an extra ~20 MB download when rebasing atop latest master. Once we have a submodule bump landing after rust-lang#76332, we can fix this behavior to reduce downloads further.
    Dylan-DPC authored Sep 12, 2020
    Configuration menu
    Copy the full SHA
    2beb32c View commit details
    Browse the repository at this point in the history
  18. Rollup merge of rust-lang#76571 - lzutao:rustdoc-private-traits, r=jy…

    …n514
    
    Ignore rustc_private items from std docs
    
    By ignoring rustc_private items for non local impl block,
    this may fix rust-lang#74672 and fix rust-lang#75588 .
    
    This might suppress rust-lang#76529 if it is simple enough for backport.
    Dylan-DPC authored Sep 12, 2020
    Configuration menu
    Copy the full SHA
    fcf82df View commit details
    Browse the repository at this point in the history
  19. Rollup merge of rust-lang#76585 - Aaron1011:ignore-vert-plus, r=petro…

    …chenkov
    
    Ignore `|` and `+` tokens during proc-macro pretty-print check
    
    Fixes rust-lang#76182
    
    This is an alternative to PR rust-lang#76188
    
    These tokens are not preserved in the AST in certain cases
    (e.g. a leading `|` in a pattern or a trailing `+` in a trait bound).
    
    This PR ignores them entirely during the pretty-print/reparse check
    to avoid spuriously using the re-parsed tokenstream.
    Dylan-DPC authored Sep 12, 2020
    Configuration menu
    Copy the full SHA
    c480b71 View commit details
    Browse the repository at this point in the history
  20. Rollup merge of rust-lang#76588 - guswynn:debug_logging, r=jyn514,Mar…

    …k-Simulacrum
    
    Add a dedicated debug-logging option to config.toml
    
    @Mark-Simulacrum and I were talking in zulip and we found that turning on debug/trace logging in rustc is fairly confusing, as it effectively depends on debug-assertions and is not documented as such. @Mark-Simulacrum mentioned that we should probably have a separate option for logging anyways.
    
    this diff adds that, having the option follow debug-assertions (so everyone's existing config.toml should be fine) and if the option is false
    
    to test I ran ./x.py test <something> twice, once with `debug-logging = false` and once with `debug-logging = true` and made sure i only saw trace's when it was true
    Dylan-DPC authored Sep 12, 2020
    Configuration menu
    Copy the full SHA
    8b583f8 View commit details
    Browse the repository at this point in the history
  21. Rollup merge of rust-lang#76598 - ad-anssi:diagnostic_errors_fix, r=e…

    …stebank
    
    Fixing memory exhaustion when formatting short code suggestion
    
    Details can be found in issue rust-lang#76597. This PR replaces substractions with `saturating_sub`'s to avoid usize wrapping leading to memory exhaustion when formatting short suggestion messages.
    Dylan-DPC authored Sep 12, 2020
    Configuration menu
    Copy the full SHA
    e38a60e View commit details
    Browse the repository at this point in the history
  22. Rollup merge of rust-lang#76623 - slightlyoutofphase:master, r=jyn514

    Use `is_unstable_const_fn` instead of `is_min_const_fn` in rustdoc where appropriate
    
    This closes rust-lang#76501. Specifically, it allows for nightly users with the `#![feature(const_fn)]` flag enabled to still have their `const fn` declarations documented as such, while retaining the desired behavior that rustdoc *not* document functions that have the `rustc_const_unstable` attribute as `const`.
    Dylan-DPC authored Sep 12, 2020
    Configuration menu
    Copy the full SHA
    32f4f63 View commit details
    Browse the repository at this point in the history
  23. Rollup merge of rust-lang#76629 - pickfire:patch-4, r=jonas-schievink

    Simplify iter zip struct doc
    Dylan-DPC authored Sep 12, 2020
    Configuration menu
    Copy the full SHA
    23f2587 View commit details
    Browse the repository at this point in the history
  24. Rollup merge of rust-lang#76641 - nox:pointee-random-stuff, r=eddyb

    Some cleanup changes and commenting
    
    r? @nikomatsakis
    Cc @eddyb
    Dylan-DPC authored Sep 12, 2020
    Configuration menu
    Copy the full SHA
    177a2c8 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    a91dd7f View commit details
    Browse the repository at this point in the history
  26. Rollup merge of rust-lang#76651 - nicholasbishop:bishop-remove-window…

    …s-note, r=Mark-Simulacrum
    
    Remove Windows details from Unix and VmWorks symlink() docstrings
    
    This note is not relevant to other operating systems.
    Dylan-DPC authored Sep 12, 2020
    Configuration menu
    Copy the full SHA
    82d93d2 View commit details
    Browse the repository at this point in the history