-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 10 pull requests #77798
Rollup of 10 pull requests #77798
Commits on Sep 25, 2020
-
Link to documentation-specific guidelines.
Changed because it's not obvious how to get from the previously used URL to the documentation-specific content. This is partly because the original URL was previously changed to point to different content: * https://github.com/rust-lang/rust/pull/74037/files#diff-242481015141f373dcb178e93cffa850L88 * rust-lang@3f6928f#diff-6a3371457528722a734f3c51d9238c13L12
Configuration menu - View commit details
-
Copy full SHA for e4943ac - Browse repository at this point
Copy the full SHA e4943acView commit details
Commits on Oct 8, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 176b965 - Browse repository at this point
Copy the full SHA 176b965View commit details
Commits on Oct 9, 2020
-
Noticed a potential bug in
eat_while()
: it doesn't account for numb……er of UTF8 bytes. Fixed it by inlining it in the two places where the count is used and simplified the logic there.
Julian Wollersberger committedOct 9, 2020 Configuration menu - View commit details
-
Copy full SHA for bd49ded - Browse repository at this point
Copy the full SHA bd49dedView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6cd9b88 - Browse repository at this point
Copy the full SHA 6cd9b88View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1911d21 - Browse repository at this point
Copy the full SHA 1911d21View commit details -
Configuration menu - View commit details
-
Copy full SHA for b6bedc8 - Browse repository at this point
Copy the full SHA b6bedc8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c97c24 - Browse repository at this point
Copy the full SHA 0c97c24View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8818fda - Browse repository at this point
Copy the full SHA 8818fdaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7993ddd - Browse repository at this point
Copy the full SHA 7993dddView commit details -
Configuration menu - View commit details
-
Copy full SHA for 18318a9 - Browse repository at this point
Copy the full SHA 18318a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 217d6f9 - Browse repository at this point
Copy the full SHA 217d6f9View commit details
Commits on Oct 10, 2020
-
doc: disambiguate stat in MetadataExt::as_raw_stat
A few architectures in `os::linux::raw` import `libc::stat`, rather than defining that type directly. However, that also imports the _function_ called `stat`, which makes this doc link ambiguous: error: `crate::os::linux::raw::stat` is both a struct and a function --> library/std/src/os/linux/fs.rs:21:19 | 21 | /// [`stat`]: crate::os::linux::raw::stat | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ ambiguous link | = note: `-D broken-intra-doc-links` implied by `-D warnings` help: to link to the struct, prefix with the item type | 21 | /// [`stat`]: struct@crate::os::linux::raw::stat | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: to link to the function, add parentheses | 21 | /// [`stat`]: crate::os::linux::raw::stat() | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ We want the `struct`, so it's now prefixed accordingly.
Configuration menu - View commit details
-
Copy full SHA for f200c1e - Browse repository at this point
Copy the full SHA f200c1eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 55e92f9 - Browse repository at this point
Copy the full SHA 55e92f9View commit details -
Update
changelog-seen
in config.toml.exampleThis got out of sync when the version was bumped last time. Long-term we may want to find an easier way to maintain this that doesn't require bumping the version in three different places. Off the top of my head I can't think of anything, though.
Configuration menu - View commit details
-
Copy full SHA for d2ca0c4 - Browse repository at this point
Copy the full SHA d2ca0c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 66369a6 - Browse repository at this point
Copy the full SHA 66369a6View commit details -
Co-authored-by: Joshua Nelson <joshua@yottadb.com>
Configuration menu - View commit details
-
Copy full SHA for 8688fa8 - Browse repository at this point
Copy the full SHA 8688fa8View commit details -
Clarify the debug-related values should take boolean
They should take boolean values and the current placeholders are confusing, at least for me.
Configuration menu - View commit details
-
Copy full SHA for 2224e26 - Browse repository at this point
Copy the full SHA 2224e26View commit details -
Rollup merge of rust-lang#77195 - follower:patch-2, r=jyn514
Link to documentation-specific guidelines. Changed contribution information URL because it's not obvious how to get from the current URL to the documentation-specific content. The current URL points to this "Getting Started" page, which contains nothing specific about documentation[*] and instead launches into how to *build* `rustc` which is not a strict prerequisite for contributing documentation fixes: * https://rustc-dev-guide.rust-lang.org/getting-started.html [*] The most specific content is a "Writing documentation" bullet point which is not itself a link to anything (I guess a patch for that might be helpful too). ### Why? Making this change will make it easier for people who wish to make small "drive by" documentation fixes (and read contribution guidelines ;) ) which I find are often how I start contributing to a project. (Exhibit A: rust-lang#77050 :) ) ### Background My impression is the change of content linked is an unintentional change due to a couple of other changes: * Originally, the link pointed to `contributing.md` which started with a "table of contents" linking to each section. But the content in `contributing.md` was removed and replaced with a link to the "Getting Started" section here: * rust-lang@3f6928f#diff-6a3371457528722a734f3c51d9238c13L1 But the changed link doesn't actually point to the equivalent content, which is now located here: * https://rustc-dev-guide.rust-lang.org/contributing.html (If the "Guide to Rustc Development" is now considered the canonical location of "How to Contribute" content it might be a good idea to merge some of the "Contributing" Introduction section into the "Getting Started" section.) * This was then compounded by changing the link from `contributing.md` to `contributing.html` here: * https://github.com/rust-lang/rust/pull/74037/files#diff-242481015141f373dcb178e93cffa850L88 In order to even find the new location of the previous `contributing.md` content I ended up needing to do a GitHub search of the `rust-lang` org for the phrase "Documentation improvements are very welcome". :D
Configuration menu - View commit details
-
Copy full SHA for 1b13443 - Browse repository at this point
Copy the full SHA 1b13443View commit details -
Rollup merge of rust-lang#77629 - Julian-Wollersberger:recomputeRawSt…
…rError, r=varkor Cleanup of `eat_while()` in lexer The size of a lexer Token was inflated by the largest `TokenKind` variants `LiteralKind::RawStr` and `RawByteStr`, because * it used `usize` although `u32` is sufficient in rustc, since crates must be smaller than 4GB, * and it stored the 20 bytes big `RawStrError` enum for error reporting. If a raw string is invalid, it now needs to be reparsed to get the `RawStrError` data, but that is a very cold code path. Technically this breaks other tools that depend on rustc_lexer because they are now also restricted to a max file size of 4GB. But this shouldn't matter in practice, and rustc_lexer isn't stable anyway. Can I also get a perf run? Edit: This makes no difference in performance. The PR now only contains a small cleanup.
Configuration menu - View commit details
-
Copy full SHA for c14c9ba - Browse repository at this point
Copy the full SHA c14c9baView commit details -
Rollup merge of rust-lang#77709 - pickfire:patch-1, r=jyn514
Link Vec leak doc to Box
Configuration menu - View commit details
-
Copy full SHA for 45e3574 - Browse repository at this point
Copy the full SHA 45e3574View commit details -
Rollup merge of rust-lang#77738 - RalfJung:alloc-error-handler-commen…
…t, r=Amanieu fix __rust_alloc_error_handler comment `__rust_alloc_error_handler` was added in the same `extern` block as the allocator functions, but the comment there was not actually correct for `__rust_alloc_error_handler`. So move it down to the rest of the default allocator handling with a fixed comment. At least the comment reflects my understanding of what happens, please check carefully. :) r? @Amanieu Cc @haraldh
Configuration menu - View commit details
-
Copy full SHA for b6b6bc0 - Browse repository at this point
Copy the full SHA b6b6bc0View commit details -
Rollup merge of rust-lang#77748 - mati865:dead-code-cleanup, r=petroc…
…henkov Dead code cleanup in windows-gnu std Closes rust-lang#77622 This is the only leftover I could find.
Configuration menu - View commit details
-
Copy full SHA for 8368588 - Browse repository at this point
Copy the full SHA 8368588View commit details -
Rollup merge of rust-lang#77754 - bugadani:find_map_relevant_impl, r=…
…matthewjasper Add TraitDef::find_map_relevant_impl This PR adds a method to `TraitDef`. While `for_each_relevant_impl` covers the general use case, sometimes it's not necessary to scan through all the relevant implementations, so this PR introduces a new method, `find_map_relevant_impl`. I've also replaced the `for_each_relevant_impl` calls where possible. I'm hoping for a tiny bit of efficiency gain here and there.
Configuration menu - View commit details
-
Copy full SHA for 8752b43 - Browse repository at this point
Copy the full SHA 8752b43View commit details -
Rollup merge of rust-lang#77766 - JohnTitor:fix-debug-config, r=jyn514
Clarify the debug-related values should take boolean rust-lang#76588 tweaked their placeholders but these values should take boolean and the current placeholders are confusing, at least for me.
Configuration menu - View commit details
-
Copy full SHA for 95d4215 - Browse repository at this point
Copy the full SHA 95d4215View commit details -
Rollup merge of rust-lang#77777 - cuviper:doc-stat, r=jonas-schievink
doc: disambiguate stat in MetadataExt::as_raw_stat A few architectures in `os::linux::raw` import `libc::stat`, rather than defining that type directly. However, that also imports the _function_ called `stat`, which makes this doc link ambiguous: error: `crate::os::linux::raw::stat` is both a struct and a function --> library/std/src/os/linux/fs.rs:21:19 | 21 | /// [`stat`]: crate::os::linux::raw::stat | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ ambiguous link | = note: `-D broken-intra-doc-links` implied by `-D warnings` help: to link to the struct, prefix with the item type | 21 | /// [`stat`]: struct@crate::os::linux::raw::stat | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: to link to the function, add parentheses | 21 | /// [`stat`]: crate::os::linux::raw::stat() | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ We want the `struct`, so it's now prefixed accordingly.
Configuration menu - View commit details
-
Copy full SHA for 82c538c - Browse repository at this point
Copy the full SHA 82c538cView commit details -
Rollup merge of rust-lang#77782 - nhayama:fix-typo, r=jonas-schievink
Fix typo in error code description s/abitrary/arbitrary/
Configuration menu - View commit details
-
Copy full SHA for 612fe9f - Browse repository at this point
Copy the full SHA 612fe9fView commit details -
Rollup merge of rust-lang#77787 - jyn514:consistent-versions, r=spast…
…orino Update `changelog-seen` in config.toml.example This got out of sync when the version was bumped last time in rust-lang#77133 Long-term we may want to find an easier way to maintain this that doesn't require bumping the version in three different places. Off the top of my head I can't think of anything, though. It _is_ documented in src/bootstrap/README.md, although I don't know how many people read that. r? @Mark-Simulacrum cc @spastorino
Configuration menu - View commit details
-
Copy full SHA for c98b3e8 - Browse repository at this point
Copy the full SHA c98b3e8View commit details