Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the hermit target typecheck #78304

Closed
wants to merge 1 commit into from
Closed

Make the hermit target typecheck #78304

wants to merge 1 commit into from

Conversation

CDirkx
Copy link
Contributor

@CDirkx CDirkx commented Oct 23, 2020

Currently the tier 3 Hermit targets (x86_64-unknown-hermit etc) have errors when building, this PR makes them at least pass cargo check.

Adds the missing types:

  • std::sys::mutex::MovableMutex (Box<std::sys::mutex::Mutex>)
  • std::sys::process::CommandArgs (std::iter::Empty<&OsStr>)

Adds stub implementations to std::sys::process::Command for the following missing methods:

  • get_args
  • get_current_dir
  • get_program
  • get_envs

@CDirkx
Make the hermit target typecheck
e536e81 
Adds the missing types:
 - `std::sys::mutex::MovableMutex` (`Box<std::sys::mutex::Mutex>`)
 - `std::sys::process::CommandArgs` (`std::iter::Empty<&OsStr>`)

Adds stub implementations to `std::sys::process::Command` for the following missing methods:
 - `get_args`
 - `get_current_dir`
 - `get_program`
 - `get_envs`
@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 23, 2020
@CDirkx
Copy link
Contributor Author

CDirkx commented Oct 23, 2020

This change would make std::sys::hermit::process nearly identical to std::sys::unsupported::process, perhaps it is better to just re-export that module instead?

@m-ou-se
Copy link
Member

m-ou-se commented Oct 23, 2020

Looks like this was already done by #77610, which is about to be merged.

@CDirkx
Copy link
Contributor Author

CDirkx commented Oct 23, 2020

Ah I see, then I'm closing this PR.

@CDirkx CDirkx closed this Oct 23, 2020
@CDirkx CDirkx deleted the hermit branch October 25, 2020 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CDirkx @rust-highfive @m-ou-se @Mark-Simulacrum