Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make anonymous binders start at 0 #78545

Merged
merged 1 commit into from
Oct 30, 2020
Merged

Make anonymous binders start at 0 #78545

merged 1 commit into from
Oct 30, 2020

Conversation

jackh726
Copy link
Member

A few changes to some test outputs, but these actually look more correct to me.

@rust-highfive
Copy link
Collaborator

r? @oli-obk

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 29, 2020
@jyn514 jyn514 added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Oct 30, 2020
@jyn514
Copy link
Member

jyn514 commented Oct 30, 2020

// FIXME(eddyb) for some reason, anonymize_late_bound_regions starts at 1.

cc @eddyb, this is now being fixed :)

@oli-obk
Copy link
Contributor

oli-obk commented Oct 30, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Oct 30, 2020

📌 Commit 41ce397 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 30, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 30, 2020
Rollup of 8 pull requests

Successful merges:

 - rust-lang#77334 (Reorder benches const variable)
 - rust-lang#77888 (Simplify a nested bool match)
 - rust-lang#77921 (f64: Refactor collapsible_if)
 - rust-lang#78523 (Revert invalid `fn` return type parsing change)
 - rust-lang#78524 (Avoid BorrowMutError with RUSTC_LOG=debug)
 - rust-lang#78545 (Make anonymous binders start at 0)
 - rust-lang#78554 (Improve wording of `core::ptr::drop_in_place` docs)
 - rust-lang#78556 (Link to pass docs from NRVO module docs)

Failed merges:

 - rust-lang#78424 (Fix some more clippy warnings)

r? `@ghost`
@bors bors merged commit 05f80f0 into rust-lang:master Oct 30, 2020
@rustbot rustbot added this to the 1.49.0 milestone Oct 30, 2020
@jackh726 jackh726 deleted the anonymous branch October 30, 2020 15:41
@eddyb
Copy link
Member

eddyb commented Nov 3, 2020

Nice! cc @nikomatsakis (just in case there was some obscure reason for this, though I somewhat doubt it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants