Make keyboard interactions in the settings menu more pleasant #78876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
rust-highfive
added
the
S-waiting-on-review
jyn514
added
A-rustdoc-ui
jyn514
reviewed
Nov 8, 2020
| @@ -50,5 +66,5 @@ | |||
| } | |||
| } | |||
|
|
|||
| setEvents(); | |||
| window.addEventListener("DOMContentLoaded", setEvents); | |||
There was a problem hiding this comment.
I realized that the script was loaded before the DOM. In itself, it seems to be working but I guess it doesn't hurt to be sure that the DOM is actually there before trying to work on it.
Not really. It'll be possible to use it only when it's in but the changes don't conflict. |
|
Updated! |
notriddle
requested changes
Nov 8, 2020
GuillaumeGomez
force-pushed
the
better-setting-keyboard-ux
branch
from
b9cb1e6
to
22f39f9
Compare
Do you mind rebasing this so it's possible to test? Right now I can't try it out. |
jyn514
added
S-waiting-on-author
GuillaumeGomez
force-pushed
the
better-setting-keyboard-ux
branch
from
22f39f9
to
14ecee7
Compare
|
Done! You can now test with all changes included. |
GuillaumeGomez
added
S-waiting-on-review
|
@bors r+ Works great, thanks! |
|
📌 Commit 14ecee7 has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Nov 30, 2020
…ard-ux, r=jyn514 Make keyboard interactions in the settings menu more pleasant rust-lang#78868 improved the keyboard interactions with the settings page. This PR goes a bit further by allowing more than just "space" to toggle the checkboxes. r? `@jyn514`
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#78868 improved the keyboard interactions with the settings page. This PR goes a bit further by allowing more than just "space" to toggle the checkboxes.
r? @jyn514