Get rid of highlight::Class::None
#79069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mostly me learning the codebase, so feel free to close the PR. It does have the small benefit that we statically know rustdoc isn't generating useless `span`s, though.
jyn514
added
C-cleanup
rust-highfive
added
the
S-waiting-on-review
GuillaumeGomez
approved these changes
Nov 17, 2020
|
I actually think it's a good idea. It's more straight-forward so let's go for it! @bors: r+ rollup |
|
📌 Commit 279bf29 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 17, 2020
Rollup of 8 pull requests Successful merges: - rust-lang#74293 (Rustdoc test compiler output color) - rust-lang#78702 ([self-profiling] Include the estimated size of each cgu in the profile) - rust-lang#79069 (Get rid of `highlight::Class::None`) - rust-lang#79072 (Fix exhaustiveness in case a byte string literal is used at slice type) - rust-lang#79120 (update rustfmt to v1.4.27) - rust-lang#79125 (Get rid of clean::{Method, TyMethod}) - rust-lang#79126 (Remove duplicate `Trait::auto` field) - rust-lang#79130 (extend macro braces test) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly me learning the codebase for #77939, so feel free to close the PR.
It does have the small benefit that we statically know rustdoc isn't generating useless
spans, though.r? @GuillaumeGomez
cc @matklad