Rollup of 6 pull requests #79672
Closed
Rollup of 6 pull requests #79672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Broken in rust-lang#79038
The span was unused.
…s, r=lcnr Doc keyword lint pass `x.py test` doesn't seem to work locally for multiple reasons so simpler to just run CI...
…lacrum Fix SGX CI Broken in rust-lang#79038
Use more std:: instead of core:: in docs for consistency `@rustbot` label T-doc Some cleanup work to use `std::` instead of `core::` in docs as much as possible. This helps with terminology and consistency, especially for newcomers from other languages that have often heard of `std` to describe the standard library but not of `core`. Edit: I also added more intra doc links when I saw the opportunity.
Pass around Symbols instead of Idents in doctree The span was unused. Vaguely related to rust-lang#78082 - currently working on converting `visit_ast` to use `hir::intravisit` and this makes that a little easier. r? `@GuillaumeGomez`
disable a ptr equality test on Miri This test relies on deduplication of constants. I do not think that this is a *guarantee* that Rust currently makes, and indeed Miri does not deduplicate constants the same way that rustc does, leading to different behavior in this test. For now, I propose we simply disable this test in Miri.
move interpret::MemoryKind::Heap to const eval r? `@oli-obk`
|
@bors: r+ p=6 |
|
📌 Commit 9e545f7 has been approved by |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit 9e545f7 with merge 505ad981d562c8adadc12d0ee53eae736c7bd453... |
|
💥 Test timed out |
bors
added
S-waiting-on-review
|
Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup