Added missing memory orderings for atomic types. #7993
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If the behavior is same as in C++11, they are similar but not exactly the same. SeqCst also guarantees a total ordering. Source: http://en.cppreference.com/w/cpp/atomic/memory_order |
|
Ah, thank you. So most of the places where we use SeqCst actually only need AcqRel, and there's a performance penalty associated with SeqCst, even on x86. |
bors
added a commit
that referenced
this pull request
Jul 24, 2013
Added missing memory orderings for atomic types. #7422
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Dec 2, 2021
`no_std_swap`: Fix typo in TODO changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing memory orderings for atomic types. #7422