Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve and fix diagnostics of exhaustiveness checking #80104

Merged
merged 7 commits into from
Dec 19, 2020
Merged

Improve and fix diagnostics of exhaustiveness checking #80104

merged 7 commits into from
Dec 19, 2020

Commits on Dec 18, 2020

  1. Add tests

    @Nadrieril
    Nadrieril committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    2309783 View commit details
    Browse the repository at this point in the history

  2. Factor out or-pattern usefulness merging

    @Nadrieril
    Nadrieril committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    7009d20 View commit details
    Browse the repository at this point in the history

  3. Log the output of is_useful in the or-pattern case too

    @Nadrieril
    Nadrieril committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    170fae2 View commit details
    Browse the repository at this point in the history

  4. Rewrite usefulness merging using SpanSet 

    `SpanSet` is heavily inspired from `DefIdForest`.
    @Nadrieril
    Nadrieril committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    d7a6365 View commit details
    Browse the repository at this point in the history

  5. Keep all witnesses of non-exhaustiveness

    @Nadrieril
    Nadrieril committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    2d71a0b View commit details
    Browse the repository at this point in the history

  6. Merge unreachable subpatterns correctly

    @Nadrieril
    Nadrieril committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    6319d73 View commit details
    Browse the repository at this point in the history

  7. Unify the two kinds of usefulness merging 

    This is elegant but a bit of a perf gamble. That said, or-patterns
rarely have many branches and it's easy to optimize or revert if we ever
need to. In the meantime simpler code is worth it.
    @Nadrieril
    Nadrieril committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    cefcadb View commit details
    Browse the repository at this point in the history