-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 15 pull requests #81437
Rollup of 15 pull requests #81437
Commits on Jan 10, 2021
-
Print failure message on all tests that should panic, but don't
This already happens with should_panic tests without an expected message. This commit fixes should_panic tests with an expected message to have the same behavior.
Configuration menu - View commit details
-
Copy full SHA for b43aa96 - Browse repository at this point
Copy the full SHA b43aa96View commit details
Commits on Jan 16, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 2624b3e - Browse repository at this point
Copy the full SHA 2624b3eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3056dd0 - Browse repository at this point
Copy the full SHA 3056dd0View commit details -
Configuration menu - View commit details
-
Copy full SHA for b8115b8 - Browse repository at this point
Copy the full SHA b8115b8View commit details
Commits on Jan 18, 2021
-
Reset LateContext enclosing body in nested items
Prevents LateContext::maybe_typeck_results() from returning data in a nested item without a body. Consequently, LateContext::qpath_res is less likely to ICE when called in a nested item. Would have prevented rust-lang/rust-clippy#4545, presumably.
Configuration menu - View commit details
-
Copy full SHA for 63a1eee - Browse repository at this point
Copy the full SHA 63a1eeeView commit details -
Query for TypeckResults in LateContext::qpath_res
Actually fulfills the documented guarantees.
Configuration menu - View commit details
-
Copy full SHA for 21fb586 - Browse repository at this point
Copy the full SHA 21fb586View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0724573 - Browse repository at this point
Copy the full SHA 0724573View commit details -
Configuration menu - View commit details
-
Copy full SHA for 933bb18 - Browse repository at this point
Copy the full SHA 933bb18View commit details -
Configuration menu - View commit details
-
Copy full SHA for 50e1ae1 - Browse repository at this point
Copy the full SHA 50e1ae1View commit details -
Configuration menu - View commit details
-
Copy full SHA for e0d64b9 - Browse repository at this point
Copy the full SHA e0d64b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for eaba3da - Browse repository at this point
Copy the full SHA eaba3daView commit details
Commits on Jan 22, 2021
-
Make more traits of the From/Into family diagnostic items
Following traits are now diagnostic items: - `From` (unchanged) - `Into` - `TryFrom` - `TryInto` This also adds symbols for those items: - `into_trait` - `try_from_trait` - `try_into_trait`
Configuration menu - View commit details
-
Copy full SHA for e25959b - Browse repository at this point
Copy the full SHA e25959bView commit details
Commits on Jan 23, 2021
-
Make
-Z time-passes
less noisy- Add the module name to `pre_AST_expansion_passes` and don't make it a verbose event (since it normally doesn't take very long, and it's emitted many times) - Don't make the following rustdoc events verbose; they're emitted many times. + build_extern_trait_impl + build_local_trait_impl + build_primitive_trait_impl + get_auto_trait_impls + get_blanket_trait_impls - Remove `get_auto_trait_and_blanket_synthetic_impls`; it's wholly covered by get_{auto,blanket}_trait_impls and not very useful.
Configuration menu - View commit details
-
Copy full SHA for 3b8f1b7 - Browse repository at this point
Copy the full SHA 3b8f1b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for f241c10 - Browse repository at this point
Copy the full SHA f241c10View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5aa625b - Browse repository at this point
Copy the full SHA 5aa625bView commit details
Commits on Jan 24, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 8a18fb0 - Browse repository at this point
Copy the full SHA 8a18fb0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 48f9dbf - Browse repository at this point
Copy the full SHA 48f9dbfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d4e03a - Browse repository at this point
Copy the full SHA 6d4e03aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 77a9e3e - Browse repository at this point
Copy the full SHA 77a9e3eView commit details
Commits on Jan 25, 2021
-
Point to span of upvar making closure FnMut
Add expected error Add comment Tweak comment wording Fix after rebase to updated master Fix after rebase to updated master Distinguish mutation in normal and move closures Tweak error message Fix error message for nested closures Refactor code showing mutated upvar in closure Remove debug assert B
Configuration menu - View commit details
-
Copy full SHA for 26b4baf - Browse repository at this point
Copy the full SHA 26b4bafView commit details -
Configuration menu - View commit details
-
Copy full SHA for ef3127d - Browse repository at this point
Copy the full SHA ef3127dView commit details -
Improve URL handling when clicking on a menu link while being on the …
…search results and overall
Configuration menu - View commit details
-
Copy full SHA for 09518db - Browse repository at this point
Copy the full SHA 09518dbView commit details
Commits on Jan 26, 2021
-
Configuration menu - View commit details
-
Copy full SHA for cf71d83 - Browse repository at this point
Copy the full SHA cf71d83View commit details
Commits on Jan 27, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 582a171 - Browse repository at this point
Copy the full SHA 582a171View commit details -
Configuration menu - View commit details
-
Copy full SHA for b519deb - Browse repository at this point
Copy the full SHA b519debView commit details -
Rollup merge of #70904 - LukasKalbertodt:stabilize-seek-convenience, …
…r=m-ou-se Stabilize `Seek::stream_position` (feature `seek_convenience`) Tracking issue: #59359 Unresolved questions from tracking issue: - "Override `stream_len` for `File`?" → we can do that in the future, this does not block stabilization. - "Rename to `len` and `position`?" → as noted in the tracking issue, both of these shorter names have problems (`len` is usually a cheap getter, `position` clashes with `Cursor`). I do think the current names are perfectly fine. - "Rename `stream_position` to `tell`?" → as mentioned in [the comment bringing this up](#59359 (comment)), `stream_position` is more descriptive. I don't think `tell` would be a good name. What remains to decide, is whether or not adding these methods is worth it.
Configuration menu - View commit details
-
Copy full SHA for f96a67c - Browse repository at this point
Copy the full SHA f96a67cView commit details -
Rollup merge of #79951 - LeSeulArtichaut:ty-ir, r=nikomatsakis
Refractor a few more types to `rustc_type_ir` In the continuation of #79169, ~~blocked on that PR~~. This PR: - moves `IntVarValue`, `FloatVarValue`, `InferTy` (and friends) and `Variance` - creates the `IntTy`, `UintTy` and `FloatTy` enums in `rustc_type_ir`, based on their `ast` and `chalk_ir` equilavents, and uses them for types in the rest of the compiler. ~~I will split up that commit to make this easier to review and to have a better commit history.~~ EDIT: done, I split the PR in commits of 200-ish lines each r? ``@nikomatsakis`` cc ``@jackh726``
Configuration menu - View commit details
-
Copy full SHA for c340661 - Browse repository at this point
Copy the full SHA c340661View commit details -
Rollup merge of #80868 - johanngan:should-panic-msg-with-expected, r=…
…m-ou-se Print failure message on all tests that should panic, but don't Fixes #80861. Tests with the `#[should_panic]` attribute should always print a failure message if no panic occurs, regardless of whether or not an `expected` panic message is specified.
Configuration menu - View commit details
-
Copy full SHA for 4fa9e70 - Browse repository at this point
Copy the full SHA 4fa9e70View commit details -
Rollup merge of #81062 - sexxi-goose:precise_capture_diagnostics, r=n…
…ikomatsakis Improve diagnostics for Precise Capture This is just the capture analysis part and borrow checker logging will updated as part of rust-lang/project-rfc-2229#8 Closes rust-lang/project-rfc-2229#22
Configuration menu - View commit details
-
Copy full SHA for 955e015 - Browse repository at this point
Copy the full SHA 955e015View commit details -
Rollup merge of #81158 - 1000teslas:issue-80313-fix, r=Aaron1011
Point to span of upvar making closure FnMut For #80313.
Configuration menu - View commit details
-
Copy full SHA for d20e044 - Browse repository at this point
Copy the full SHA d20e044View commit details -
Rollup merge of #81176 - camsteffen:qpath-res, r=oli-obk
Improve safety of `LateContext::qpath_res` This is my first rustc code change, inspired by hacking on clippy! The first change is to clear cached `TypeckResults` from `LateContext` when visiting a nested item. I took a hint from [here](https://github.com/rust-lang/rust/blob/5e91c4ecc09312d8b63d250a432b0f3ef83f1df7/compiler/rustc_privacy/src/lib.rs#L1300). Clippy has a `qpath_res` util function to avoid a possible ICE in `LateContext::qpath_res`. But the docs of `LateContext::qpath_res` promise no ICE. So this updates the `LateContext` method to keep its promises, and removes the util function. Related: rust-lang/rust-clippy#4545 CC ````````@eddyb```````` since you've done related work CC ````````@flip1995```````` FYI
Configuration menu - View commit details
-
Copy full SHA for 9e0013a - Browse repository at this point
Copy the full SHA 9e0013aView commit details -
Rollup merge of #81277 - flip1995:from_diag_items, r=matthewjasper
Make more traits of the From/Into family diagnostic items Following traits are now diagnostic items: - `From` (unchanged) - `Into` - `TryFrom` - `TryInto` This also adds symbols for those items: - `into_trait` - `try_from_trait` - `try_into_trait` Related: rust-lang/rust-clippy#6620 (comment)
Configuration menu - View commit details
-
Copy full SHA for 9983e9f - Browse repository at this point
Copy the full SHA 9983e9fView commit details -
Rollup merge of #81284 - jyn514:impl-times, r=wesleywiser
Make `-Z time-passes` less noisy - Add the module name to `pre_AST_expansion_passes` and don't make it a verbose event (since it normally doesn't take very long, and it's emitted many times) - Don't make the following rustdoc events verbose; they're emitted many times. + build_extern_trait_impl + build_local_trait_impl + build_primitive_trait_impl + get_auto_trait_impls + get_blanket_trait_impls - Remove the `get_auto_trait_and_blanket_synthetic_impls` rustdoc event; it's wholly covered by get_{auto,blanket}_trait_impls and not very useful. I found this while working on #81275 but it's independent of those changes.
Configuration menu - View commit details
-
Copy full SHA for b74f5fd - Browse repository at this point
Copy the full SHA b74f5fdView commit details -
Rollup merge of #81306 - SkiFire13:fuse-flatten, r=cuviper
Fuse inner iterator in FlattenCompat and improve related tests Fixes #81248
Configuration menu - View commit details
-
Copy full SHA for 8ad6d14 - Browse repository at this point
Copy the full SHA 8ad6d14View commit details -
Rollup merge of #81327 - RalfJung:codegen-no-const-fail, r=oli-obk
codegen: assume constants cannot fail to evaluate #80579 landed, so we can finally remove this old hack from codegen and instead assume that consts never fail to evaluate. :) r? ``````@oli-obk``````
Configuration menu - View commit details
-
Copy full SHA for 92ce338 - Browse repository at this point
Copy the full SHA 92ce338View commit details -
Rollup merge of #81333 - RalfJung:const-err-simplify, r=oli-obk
clean up some const error reporting around promoteds These are some error reporting simplifications enabled by #80579. Further simplifications are possible but could be blocked on making `const_err` a hard error. r? ```@oli-obk```
Configuration menu - View commit details
-
Copy full SHA for f8fa0d1 - Browse repository at this point
Copy the full SHA f8fa0d1View commit details -
Rollup merge of #81351 - lcnr:big-money-big-prices, r=oli-obk
combine: stop eagerly evaluating consts `super_relate_consts` eagerly evaluates constants which doesn't seem too great. I now also finally understand why all of the unused substs test passed. The reason being that we just evaluated the constants in `super_relate_consts` 😆 While this change isn't strictly necessary as evaluating consts here doesn't hurt, it still feels a lot cleaner to do it this way r? ``@oli-obk`` ``@nikomatsakis``
Configuration menu - View commit details
-
Copy full SHA for 4f56d32 - Browse repository at this point
Copy the full SHA 4f56d32View commit details -
Rollup merge of #81379 - GuillaumeGomez:improve-urls, r=Nemo157
Improve URLs handling Fixes #81330. Explanations: before this PR, when emptying the search input, we still had `?search=` in the URL, which wasn't very nice. Now, if the search is empty, we drop the `?search=` part. Also, I realized while working on this PR that when we clicked on a menu link when we were on the search results, the search parameters would look like: `?search=#the-anchor`, which was super weird. Now, it looks like this: `?search=the-search#the-anchor`. Also, I didn't use the `Url` very nice API because it's not available in any IE version (sadness...). cc ``@lzutao`` r? ``@Nemo157``
Configuration menu - View commit details
-
Copy full SHA for 7e0cd72 - Browse repository at this point
Copy the full SHA 7e0cd72View commit details -
Rollup merge of #81430 - lcnr:elaborate-const-eval, r=oli-obk
add const_evaluatable_checked test cc ``@oli-obk``
Configuration menu - View commit details
-
Copy full SHA for 00bbc1e - Browse repository at this point
Copy the full SHA 00bbc1eView commit details -
Rollup merge of #81433 - lcnr:stop-looking-into-ty-alias, r=oli-obk
const_evaluatable: stop looking into type aliases see https://rust-lang.zulipchat.com/#narrow/stream/260443-project-const-generics/topic/const_evaluatable.3A.20type.20alias r? `@oli-obk`
Configuration menu - View commit details
-
Copy full SHA for 2ae3263 - Browse repository at this point
Copy the full SHA 2ae3263View commit details