Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try inlining trivial functions used by CTFE #81441

Merged
merged 2 commits into from
Jan 28, 2021
Merged

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Jan 27, 2021

r? @ghost

@tmiasko
Copy link
Contributor Author

tmiasko commented Jan 27, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@bors
Copy link
Contributor

bors commented Jan 27, 2021

⌛ Trying commit 20982b3 with merge 4a69f8e80de4c2a2c4efdfa2ec39d3d688deaf31...

@bors
Copy link
Contributor

bors commented Jan 27, 2021

☀️ Try build successful - checks-actions
Build commit: 4a69f8e80de4c2a2c4efdfa2ec39d3d688deaf31 (4a69f8e80de4c2a2c4efdfa2ec39d3d688deaf31)

@rust-timer
Copy link
Collaborator

Queued 4a69f8e80de4c2a2c4efdfa2ec39d3d688deaf31 with parent 613ef74, future comparison URL.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 27, 2021
@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (4a69f8e80de4c2a2c4efdfa2ec39d3d688deaf31): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jan 27, 2021
@tmiasko
Copy link
Contributor Author

tmiasko commented Jan 27, 2021

The change was targeting the ctfe-stress-4 benchmark. The full wall times show consistent improvements of -5.0%, as do incr-full runs. The detailed comparisons show improvements in eval_to_allocation_raw query as intended. All of those results are essentially at the lower end of historical results, but not particularly significant.

r? @oli-obk

@oli-obk
Copy link
Contributor

oli-obk commented Jan 28, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Jan 28, 2021

📌 Commit 20982b3 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 28, 2021
@bors
Copy link
Contributor

bors commented Jan 28, 2021

⌛ Testing commit 20982b3 with merge bf193d6...

@bors
Copy link
Contributor

bors commented Jan 28, 2021

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing bf193d6 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 28, 2021
@bors bors merged commit bf193d6 into rust-lang:master Jan 28, 2021
@rustbot rustbot added this to the 1.51.0 milestone Jan 28, 2021
@tmiasko tmiasko deleted the ctfe-inline branch January 28, 2021 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants