Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add long explanation e0521 #81634

Merged
merged 3 commits into from
Feb 3, 2021
Merged

Add long explanation e0521 #81634

merged 3 commits into from
Feb 3, 2021

Conversation

jesusprubio
Copy link
Contributor

Helps with #61137

@rust-highfive
Copy link
Collaborator

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @matthewjasper (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 1, 2021
@GuillaumeGomez
Copy link
Member

Nice, thanks!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Feb 1, 2021

📌 Commit 9ef24f9 has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 1, 2021
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Feb 1, 2021
@GuillaumeGomez
Rollup merge of rust-lang#81634 - jesusprubio:jesusprubio/add-long-ex…
3c4aca2 
…planation-e0521, r=GuillaumeGomez

Add long explanation e0521

Helps with rust-lang#61137
@GuillaumeGomez GuillaumeGomez mentioned this pull request Feb 1, 2021
Closed
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Feb 2, 2021
@JohnTitor
Rollup merge of rust-lang#81634 - jesusprubio:jesusprubio/add-long-ex…
bc33094 
…planation-e0521, r=GuillaumeGomez

Add long explanation e0521

Helps with rust-lang#61137
@JohnTitor JohnTitor mentioned this pull request Feb 2, 2021
Closed
@JohnTitor
Copy link
Member

Failed in rollup: #81652 (comment)

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 2, 2021
@jesusprubio
Copy link
Contributor Author

@GuillaumeGomez, could you call @bors for me again please? :)

@GuillaumeGomez
Copy link
Member

Seems still good, let's try again but not in a rollup this time.

@bors: r+ rollup-

@bors
Copy link
Contributor

bors commented Feb 2, 2021

📌 Commit c57889b has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 2, 2021
jackh726 added a commit to jackh726/rust that referenced this pull request Feb 2, 2021
@jackh726
Rollup merge of rust-lang#81634 - jesusprubio:jesusprubio/add-long-ex…
9757be5 
…planation-e0521, r=GuillaumeGomez

Add long explanation e0521

Helps with rust-lang#61137
This was referenced Feb 2, 2021
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 2, 2021
@bors
Auto merge of rust-lang#81678 - jackh726:rollup-3nerni4, r=jackh726
d95d4f0 
Rollup of 14 pull requests

Successful merges:

 - rust-lang#80593 (Upgrade Chalk)
 - rust-lang#81260 (Add .editorconfig)
 - rust-lang#81455 (Add AArch64 big-endian and ILP32 targets)
 - rust-lang#81517 (Remove remnants of the santizer runtime crates from bootstrap)
 - rust-lang#81530 (sys: use `process::abort()` instead of `arch::wasm32::unreachable()`)
 - rust-lang#81544 (Add better diagnostic for unbounded Abst. Const)
 - rust-lang#81588 (Add doc aliases for "delete")
 - rust-lang#81603 (rustbuild: Don't build compiler twice for error-index-generator.)
 - rust-lang#81634 (Add long explanation e0521)
 - rust-lang#81636 (Directly use `Option<&[T]>` instead of converting from `Option<&Vec<T>>` later on)
 - rust-lang#81647 (Fix bug with assert!() calling the wrong edition of panic!().)
 - rust-lang#81655 (Improve wording of suggestion about accessing field)
 - rust-lang#81665 (Fix out of date `Scalar` documentation)
 - rust-lang#81671 (Add more associated type tests)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit fd4f4ad into rust-lang:master Feb 3, 2021
@rustbot rustbot added this to the 1.51.0 milestone Feb 3, 2021
@jesusprubio jesusprubio mentioned this pull request Feb 4, 2021
Closed
@jesusprubio jesusprubio deleted the jesusprubio/add-long-explanation-e0521 branch February 6, 2021 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@matthewjasper matthewjasper

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.51.0
Development

Successfully merging this pull request may close these issues.
7 participants
@jesusprubio @rust-highfive @GuillaumeGomez @bors @JohnTitor @matthewjasper @rustbot