Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup the computation of lint levels #82985

Merged
merged 3 commits into from
Jul 6, 2021
Merged

Cleanup the computation of lint levels #82985

merged 3 commits into from
Jul 6, 2021

Conversation

cjgillot
Copy link
Contributor

@cjgillot cjgillot commented Mar 10, 2021 •
edited
Loading

This now uses an IndexVec and a special root LintStackIndex = 0 to encode command-line levels.

@cjgillot
Copy link
Contributor Author

r? @estebank

@cjgillot cjgillot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 16, 2021
@bstrie bstrie added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 31, 2021
@crlf0710 crlf0710 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 17, 2021
@JohnCSimon JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 4, 2021
@bstrie bstrie added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 19, 2021
@bors
Copy link
Contributor

bors commented Jun 4, 2021

☔ The latest upstream changes (presumably #85788) made this pull request unmergeable. Please resolve the merge conflicts.

@cjgillot
Copy link
Contributor Author

cjgillot commented Jun 4, 2021

Rebased on #86009

@crlf0710 crlf0710 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 26, 2021
@jackh726
Copy link
Member

jackh726 commented Jul 2, 2021

r? @jackh726

@bors r+

@rust-highfive rust-highfive assigned jackh726 and unassigned estebank Jul 2, 2021
@cjgillot
Copy link
Contributor Author

cjgillot commented Jul 3, 2021

Bors did not take the command.
@bors r=jackh726

1 similar comment
@cjgillot
Copy link
Contributor Author

cjgillot commented Jul 5, 2021

Bors did not take the command.
@bors r=jackh726

@cjgillot cjgillot closed this Jul 5, 2021
@cjgillot cjgillot reopened this Jul 5, 2021
@cjgillot
Copy link
Contributor Author

cjgillot commented Jul 5, 2021

Bors did not take the command.
@bors r=jackh726

@bors
Copy link
Contributor

bors commented Jul 5, 2021

📌 Commit 5a731ff has been approved by jackh726

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 5, 2021
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 5, 2021
@bors
Copy link
Contributor

bors commented Jul 6, 2021

⌛ Testing commit 5a731ff with merge d5a406b...

@bors
Copy link
Contributor

bors commented Jul 6, 2021

☀️ Test successful - checks-actions
Approved by: jackh726
Pushing d5a406b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 6, 2021
@bors bors merged commit d5a406b into rust-lang:master Jul 6, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jul 6, 2021
@cjgillot cjgillot deleted the lint branch July 6, 2021 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jackh726 jackh726

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.55.0
Development

Successfully merging this pull request may close these issues.
8 participants
@cjgillot @bors @jackh726 @crlf0710 @bstrie @estebank @JohnCSimon @rustbot