Extend proc_macro_back_compat lint to js-sys
#83306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this PR, we now lint for all cases where we perform some kind of proc-macro back-compat hack. The `js-sys` had an internal fix made to properly handle `None`-delimited groups, so we need to manually check the version in the filename. As a result, we no longer apply the back-compat hack to cases where the version number is missing file the file path. This should not affect any users of the `crates.io` crate.
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit f6a35d7 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit f6a35d7 with merge abcc4d5f2b6bdaba6b8de444a9099a1923a3fe6a... |
|
💥 Test timed out |
bors
added
S-waiting-on-review
|
@bors retry |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 21, 2021
Rollup of 6 pull requests Successful merges: - rust-lang#82707 (const_evaluatable_checked: Stop eagerly erroring in `is_const_evaluatable`) - rust-lang#83040 (extract `ConstKind::Unevaluated` into a struct) - rust-lang#83280 (Fix pluralization in keyword docs) - rust-lang#83289 (Move some tests to more reasonable directories - 5) - rust-lang#83306 (Extend `proc_macro_back_compat` lint to `js-sys`) - rust-lang#83327 (Extend comment in `UsedLocals::visit_lhs`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, we now lint for all cases where we perform some kind of
proc-macro back-compat hack.
The
js-syshad an internal fix made to properly handleNone-delimited groups, so we need to manually check the version in thefilename. As a result, we no longer apply the back-compat hack to cases
where the version number is missing file the file path. This should not
affect any users of the
crates.iocrate.