Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #83664

Merged
merged 20 commits into from
Mar 30, 2021
Merged

Rollup of 7 pull requests #83664

merged 20 commits into from
Mar 30, 2021

Commits on Feb 20, 2021

  1. Configuration menu
    Copy the full SHA
    6233f3f View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2021

  1. Configuration menu
    Copy the full SHA
    dd2b8a0 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2021

  1. unix: Fix feature(unix_socket_ancillary_data) on macos and other BSDs

    This adds support for CMSG handling on macOS and fixes it on OpenBSD
    and other BSDs.
    
    When traversing the CMSG list, the previous code had an exception for
    Android where the next element after the last pointer could point to
    the first pointer instead of NULL.  This is actually not specific to
    Android: the `libc::CMSG_NXTHDR` implementation for Linux and
    emscripten have a special case to return NULL when the length of the
    previous element is zero; most other implementations simply return the
    previous element plus a zero offset in this case.
    
    This MR additionally adds `SocketAncillary::is_empty` because clippy
    is right that it should be added.
    reyk committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    3d6bd87 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2021

  1. Configuration menu
    Copy the full SHA
    4572e7f View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2021

  1. Configuration menu
    Copy the full SHA
    c20ba9c View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2021

  1. Point to disambiguator instead of whole link

    And, now that we do that, we can remove the explanatory note since the
    error span should make it clear what the disambiguator is.
    camelid committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    56347a1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5497f15 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    141df6f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    29d4a7d View commit details
    Browse the repository at this point in the history
  5. Prefer 4 spaces

    JohnTitor committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    c9562fd View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    48f9f08 View commit details
    Browse the repository at this point in the history
  7. ⬆️ rust-analyzer

    lnicola committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    79acd5e View commit details
    Browse the repository at this point in the history
  8. Updated the tracking issue #

    frol committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    595f3f2 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#82331 - frol:feat/std-binary-heap-as-slice,…

    … r=Amanieu
    
    alloc: Added `as_slice` method to `BinaryHeap` collection
    
    I initially asked about whether it is useful addition on https://internals.rust-lang.org/t/should-i-add-as-slice-method-to-binaryheap/13816, and it seems there were no objections, so went ahead with this PR.
    
    > There is [`BinaryHeap::into_vec`](https://doc.rust-lang.org/std/collections/struct.BinaryHeap.html#method.into_vec), but it consumes the value. I wonder if there is API design limitation that should be taken into account. Implementation-wise, the inner buffer is just a Vec, so it is trivial to expose as_slice from it.
    
    Please, guide me through if I need to add tests or something else.
    
    UPD: Tracking issue rust-lang#83659
    Dylan-DPC authored Mar 29, 2021
    Configuration menu
    Copy the full SHA
    2843baa View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#83130 - clarfonthey:escape, r=m-ou-se

    escape_ascii take 2
    
    The previous PR, rust-lang#73111 was closed for inactivity; since I've had trouble in the past reopening closed PRs, I'm just making a new one.
    
    I'm still running the tests locally but figured I'd open the PR in the meantime. Will fix whatever errors show up so we don't have to wait again for this.
    
    r? ``@m-ou-se``
    Dylan-DPC authored Mar 29, 2021
    Configuration menu
    Copy the full SHA
    68964d1 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#83374 - reyk:fix/bsd-ancillary, r=joshtriplett

    unix: Fix feature(unix_socket_ancillary_data) on macos and other BSDs
    
    This adds support for CMSG handling on macOS and fixes it on OpenBSD and possibly other BSDs.
    
    When traversing the CMSG list, the previous code had an exception for Android where the next element after the last pointer could point to the first pointer instead of NULL.  This is actually not specific to Android: the `libc::CMSG_NXTHDR` implementation for Linux and emscripten have a special case to return NULL when the length of the previous element is zero; most other implementations simply return the previous element plus a zero offset in this case.
    
    This MR makes the check non-optional which fixes CMSG handling and a possible endless loop on such systems; tested with file descriptor passing on OpenBSD, Linux, and macOS.
    
    This MR additionally adds `SocketAncillary::is_empty` because clippy is right that it should be added.
    
    This belongs to the `feature(unix_socket_ancillary_data)` tracking issue:  rust-lang#76915
    
    r? `@joshtriplett`
    Dylan-DPC authored Mar 29, 2021
    Configuration menu
    Copy the full SHA
    772582e View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#83543 - camelid:lint-unknown-disambiguator,…

    … r=jyn514
    
    Lint on unknown intra-doc link disambiguators
    Dylan-DPC authored Mar 29, 2021
    Configuration menu
    Copy the full SHA
    25ade69 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#83636 - JohnTitor:const-generics-defualts-r…

    …egg-test, r=lcnr
    
    Add a regression test for issue-82792
    
    Closes rust-lang#82792
    
    r? ``@lcnr``
    Dylan-DPC authored Mar 29, 2021
    Configuration menu
    Copy the full SHA
    6b5ba53 View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#83643 - JohnTitor:is-freeze-no-longer-uses-…

    …span, r=RalfJung
    
    Remove a FIXME resolved by rust-lang#73578
    
    r? ``@RalfJung``
    Dylan-DPC authored Mar 29, 2021
    Configuration menu
    Copy the full SHA
    fca8e7d View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#83644 - lnicola:rust-analyzer-2021-03-29, r…

    …=jonas-schievink
    
    ⬆️ rust-analyzer
    Dylan-DPC authored Mar 29, 2021
    Configuration menu
    Copy the full SHA
    6738ee7 View commit details
    Browse the repository at this point in the history