Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not ignore path segments in the middle in #[allow]/#[warn]/#[deny]/#[forbid] attributes #84064

Merged
merged 1 commit into from Apr 18, 2021

Conversation

ghost
Copy link

@ghost ghost commented Apr 10, 2021

Fixes #83477.

@rust-highfive
Copy link
Collaborator

r? @lcnr

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 10, 2021
@lcnr
Copy link
Contributor

lcnr commented Apr 12, 2021

r? @petrochenkov maybe

@rust-highfive rust-highfive assigned petrochenkov and unassigned lcnr Apr 12, 2021
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Apr 16, 2021

📌 Commit 56fe372 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2021
jyn514 pushed a commit to jyn514/rust that referenced this pull request Apr 16, 2021
Do not ignore path segments in the middle in `#[allow]`/`#[warn]`/`#[deny]`/`#[forbid]` attributes

Fixes rust-lang#83477.
@bors
Copy link
Contributor

bors commented Apr 16, 2021

⌛ Testing commit 56fe372 with merge b1174302b302dbbaf97fa3be932eb2d9de5978f0...

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Contributor

bors commented Apr 16, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 16, 2021
@ghost
Copy link
Author

ghost commented Apr 17, 2021

The test failure should be fixed now, although that failed test has already been removed in Clippy 6 days ago (rust-lang/rust-clippy#7059) and will be removed here by the next Clippy update.

@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Apr 17, 2021

📌 Commit ac044e3 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 17, 2021
@bors
Copy link
Contributor

bors commented Apr 18, 2021

⌛ Testing commit ac044e3 with merge dc99219...

@bors
Copy link
Contributor

bors commented Apr 18, 2021

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing dc99219 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 18, 2021
@bors bors merged commit dc99219 into rust-lang:master Apr 18, 2021
@rustbot rustbot added this to the 1.53.0 milestone Apr 18, 2021
@ghost ghost deleted the unknown-lints branch April 18, 2021 08:14
flip1995 pushed a commit to flip1995/rust that referenced this pull request Apr 22, 2021
Do not ignore path segments in the middle in `#[allow]`/`#[warn]`/`#[deny]`/`#[forbid]` attributes

Fixes rust-lang#83477.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Referring to tool lints with paths that have redundant segments in the middle works
6 participants