Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update backtrace to 0.3.57 #84563

Merged
merged 1 commit into from
Apr 27, 2021
Merged

Update backtrace to 0.3.57 #84563

merged 1 commit into from
Apr 27, 2021

Conversation

jclulow
Copy link
Contributor

@jclulow jclulow commented Apr 25, 2021

Adds support for symbol resolution on illumos systems.

Adds support for symbol resolution on illumos systems.
@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 25, 2021
@jclulow
Copy link
Contributor Author

jclulow commented Apr 25, 2021

(will combine with the resolution to #84254 to fix stack unwinding and functional backtraces on illumos systems)

@Mark-Simulacrum
Copy link
Member

Can you say more about the newly added docs which indicate "inaccurate unwind information can lead this library to segfault" -- is any additional mitigation or whatever necessary in std to avoid problems here? I'm not quite clear if this is a case of "malformed executables -> obviously problematic" or what the situation here is in practice.

cc @alexcrichton

@alexcrichton
Copy link
Member

Oh sure yeah, that's just documenting behavior since the beginning of time, nothing is new here. Unwind information that's referring to refers to .eh_frame or the equivalent. This is generated by compilers, loaded with the rest of the executable, and parsed by _Unwind_Backtrace (or other unwinding runtimes). The backtrace crate doesn't deal with any of this itself, it's just documenting what's always been a dependency.

This is very different from debug information which is loaded at runtime (and could mismatch the executable). The backtrace crate should never segfault (pending bugs in the crate itself) on invalid or bad debug info.

tl;dr: no change, just documenting what's always been there. This isn't an issue afaik because there's no way to feed in arbitrary unwind info.

@Mark-Simulacrum
Copy link
Member

Ah sounds great, that pretty much matched what I had expected but the new docs surprised me a bit. Maybe worth a commit to clarify that segfaults aren't expected unless, like, your compiler has bugs in the unwind generation or so (which, seems true with or without the crate).

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Apr 27, 2021

📌 Commit d21fb2b has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 27, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 27, 2021
Rollup of 5 pull requests

Successful merges:

 - rust-lang#84132 (Ignore nonstandard lldb version strings in compiletest)
 - rust-lang#84521 (Reuse modules on `hermit`)
 - rust-lang#84563 (Update backtrace to 0.3.57)
 - rust-lang#84610 (Update Clippy)
 - rust-lang#84613 (move representability checks to rustc_ty_utils)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7969de2 into rust-lang:master Apr 27, 2021
@rustbot rustbot added this to the 1.53.0 milestone Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants