Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize File::options() #85766

Merged
merged 1 commit into from
Nov 16, 2021
Merged

Stabilize File::options() #85766

merged 1 commit into from
Nov 16, 2021

Conversation

workingjubilee
Copy link
Member

Renames File::with_options to File::options, per consensus in
#65439, and stabilizes it.

@rust-highfive
Copy link
Collaborator

r? @kennytm

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 27, 2021
@workingjubilee workingjubilee mentioned this pull request May 27, 2021
Closed
@jonas-schievink jonas-schievink added relnotes Marks issues that should be documented in the release notes of the next release. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels May 27, 2021
@joshtriplett
Copy link
Member

@rfcbot merge

@rfcbot
Copy link

rfcbot commented May 27, 2021 •
edited by yaahc
Loading

Team member @joshtriplett has proposed to merge this. The next step is review by the rest of the tagged team members:

Concerns:

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels May 27, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@joshtriplett
Copy link
Member

Looks like tests need updating to drop the feature gates.

@workingjubilee
Copy link
Member Author

...I keep forgetting about the doctests. Fixed.

@m-ou-se
Copy link
Member

m-ou-se commented Jun 4, 2021

@rfcbot concern bikeshed

See #65439 (comment)

This isn't to say that I will definitely block File::options(), but I do want to make sure we consider what I wrote in that comment.

(Please put any discussion/bikeshedding in the tracking issue, to avoid splitting that discussion.)

@crlf0710 crlf0710 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 26, 2021
@JohnCSimon JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 12, 2021
@JohnTitor JohnTitor added S-waiting-on-bikeshed Status: Awaiting a decision on trivial things. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 13, 2021
@crlf0710 crlf0710 added S-waiting-on-bikeshed Status: Awaiting a decision on trivial things. and removed S-waiting-on-bikeshed Status: Awaiting a decision on trivial things. labels Aug 14, 2021
@m-ou-se
Copy link
Member

m-ou-se commented Oct 20, 2021

Looks like there's no better alternative that everyone can agree on.

@rfcbot resolve bikeshed

@rfcbot rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Oct 20, 2021
@rfcbot
Copy link

rfcbot commented Oct 20, 2021

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot added the finished-final-comment-period The final comment period is finished for this PR / Issue. label Oct 30, 2021
@rfcbot
Copy link

rfcbot commented Oct 30, 2021

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

@rfcbot rfcbot removed the final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. label Oct 30, 2021
@rfcbot rfcbot added the to-announce Announce this issue on triage meeting label Oct 30, 2021
@bors
Copy link
Contributor

bors commented Oct 31, 2021

☔ The latest upstream changes (presumably #90437) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 31, 2021
@workingjubilee
Stabilize File::options()
caf206b 
Renames File::with_options to File::options, per consensus in
rust-lang#65439, and stabilizes it.
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Nov 11, 2021
@yaahc
Copy link
Member

yaahc commented Nov 15, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Nov 15, 2021

📌 Commit caf206b has been approved by yaahc

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 15, 2021
@JohnTitor JohnTitor mentioned this pull request Nov 16, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 16, 2021
@bors
Auto merge of rust-lang#90934 - JohnTitor:rollup-5soqo0j, r=JohnTitor
0206312 
Rollup of 10 pull requests

Successful merges:

 - rust-lang#85766 (Stabilize File::options())
 - rust-lang#88601 (Implement `Termination` for `Result<Infallible, E>`)
 - rust-lang#90058 (Stabilize -Z strip as -C strip)
 - rust-lang#90790 (Fix standard library test with read_link)
 - rust-lang#90834 (Android is not GNU)
 - rust-lang#90835 (Rename WASI's `is_character_device` to `is_char_device`.)
 - rust-lang#90837 (Move some tests to more reasonable directories - 9)
 - rust-lang#90848 (Remove bigint_helper_methods for *signed* types)
 - rust-lang#90892 (fix ICE on Miri/CTFE copy of half a pointer)
 - rust-lang#90909 (disable portable SIMD tests in Miri)

Failed merges:

 - rust-lang#90128 (Stabilize -Z symbol-mangling-version=v0 as -C symbol-mangling-version=v0)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 73ec27d into rust-lang:master Nov 16, 2021
@rustbot rustbot added this to the 1.58.0 milestone Nov 16, 2021
@jplatte jplatte mentioned this pull request Nov 16, 2021
Open
65 tasks
@workingjubilee workingjubilee deleted the file-options branch March 25, 2022 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kennytm kennytm

Labels
disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bikeshed Status: Awaiting a decision on trivial things. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.58.0
Development

Successfully merging this pull request may close these issues.