Rollup of 8 pull requests #87505

JohnTitor · 2021-07-27T06:39:33Z

Successful merges:

Add flag to configure large_assignments lint #86450 (Add flag to configure large_assignments lint)
Avoid ICE on type error recovery #86764 (Avoid ICE on type error recovery)
get rid of NoMirFor error variant #87427 (get rid of NoMirFor error variant)
macos current_exe using directly libc instead. #87446 (macos current_exe using directly libc instead.)
fix typo: whenver -> whenever #87494 (fix typo: whenver -> whenever)
Remove ASCII fast path from rustc_lexer::{is_id_continue, is_id_start} #87499 (Remove ASCII fast path from rustc_lexer::{is_id_continue, is_id_start})
Update cargo #87502 (Update cargo)
Update books #87503 (Update books)

Failed merges:

r? @ghost
@rustbot modify labels: rollup

The `large_assignments` lints detects moves over specified limit. The limit is configured through `move_size_limit = "N"` attribute placed at the root of a crate. When attribute is absent, the lint is disabled. Make it possible to enable the lint without making any changes to the source code, through a new flag `-Zmove-size-limit=N`. For example, to detect moves exceeding 1023 bytes in a cargo crate, including all dependencies one could use: ``` $ env RUSTFLAGS=-Zmove-size-limit=1024 cargo build -vv ```

Add flag to configure `large_assignments` lint The `large_assignments` lints detects moves over specified limit. The limit is configured through `move_size_limit = "N"` attribute placed at the root of a crate. When attribute is absent, the lint is disabled. Make it possible to enable the lint without making any changes to the source code, through a new flag `-Zmove-size-limit=N`. For example, to detect moves exceeding 1023 bytes in a cargo crate, including all dependencies one could use: ``` $ env RUSTFLAGS=-Zmove-size-limit=1024 cargo build -vv ``` Lint tracking issue rust-lang#83518.

Avoid ICE on type error recovery Fix rust-lang#86756

get rid of NoMirFor error variant The only place where we throw that error, it is very quickly caught again and turned into a different error. So raise that other error immediately.

macos current_exe using directly libc instead.

fix typo: whenver -> whenever Fix a typo in a comment in RefCell: "whenver" -> "whenever".

Remove ASCII fast path from `rustc_lexer::{is_id_continue, is_id_start}` `unicode_xid` now has a fast path built-in: unicode-rs/unicode-xid@122b387

Update cargo 8 commits in cebef2951ee69617852844894164b54ed478a7da..d21c22870e58499d6c31f1bef3bf1255eb021666 2021-07-22 13:01:52 +0000 to 2021-07-26 20:23:21 +0000 - Fix version string. (rust-lang/cargo#9727) - Allow publishing from workspace root. (rust-lang/cargo#9559) - Better msg for wrong position (rust-lang/cargo#9723) - Stabilize the rustc-link-arg option (rust-lang/cargo#9557) - Warning when using features in replace (rust-lang/cargo#9681) - Refactor if let chains to matches! macro (rust-lang/cargo#9721) - Weather is not nice today.. (rust-lang/cargo#9720) - Update should_use_metadata function (rust-lang/cargo#9653)

Update books ## nomicon 1 commits in 7a13537f96af4b9b8e3ea296d6e5c3c7ab72ce9f..f51734eb5566c826b471977747ea3d7d6915bbe9 2021-07-05 23:34:47 -0400 to 2021-07-23 18:24:35 +0900 - Add cloning example for dot operator behaviour (rust-lang/nomicon#292) ## reference 3 commits in 82d75cf423e4a7824fb36e73ccb18519d6900610..3b7be075af5d6e402a18efff672a8a265b4596fd 2021-07-15 06:49:08 -0700 to 2021-07-26 13:20:11 -0700 - Fix typos + grammar (rust-lang/reference#1037) - Expand on Unicode identifiers. (rust-lang/reference#1022) - Remove incorrect apostrophe (rust-lang/reference#1076) ## book 17 commits in eac55314210519238652f12b30fec9daea61f7fe..a07036f864b37896b31eb996cd7aedb489f69a1f 2021-07-19 11:08:01 -0400 to 2021-07-26 20:19:46 -0400 - Set expectations a bit more realistically - Snapshot of chapter 4 for nostarch - A few small wording tweaks in ch 4 - Clarify that it's not stack/heap exactly that matters for copy/non copy, fixes rust-lang/book#2799 - Clarify a detail around move. Fixes rust-lang/book#2413. - Clarify places that changed because of NLL. Fixes rust-lang/book#1939. - nostarch ch3 - Small edits to chapter 3 - (rust-lang/book#2797) - Update ch03-03-how-functions-work.md: Pervasive -> Prevalent. (rust-lang/book#2796) - Address loop labels and continue. Fixes rust-lang/book#1392. - Clarify behavior of integer division. Fixes rust-lang/book#2248. - Demonstrate how scope interacts with shadowing - Add another cross-reference to the new unit type introduction - Introduce the unit type with tuples. Fixes rust-lang/book#1933. - Reword sentence to not have numbers separated only by a comma - Link directly to other installation page. Fixes rust-lang/book#1609 ## rust-by-example 1 commits in 1db6bb483cc87ad3b424d9aba764fe622960a1be..0dc9cd4e89f00cb5230f120e1a083916386e422b 2021-07-15 06:17:42 -0300 to 2021-07-23 09:14:27 -0300 - Grammatical mistake: Comparison as ... as the (rust-lang/rust-by-example#1453) ## rustc-dev-guide 2 commits in 93422c21baca585dc88357ec886a48f6ddc7d665..09343d6f921d2a07c66f8c41ec3d65bf1fa52556 2021-07-13 12:45:58 -0400 to 2021-07-26 00:37:28 +0200 - Fix typo in building/bootstrapping.md (rust-lang/rustc-dev-guide#1175) - Link directly to stabilization report comments (rust-lang/rustc-dev-guide#1173) ## edition-guide 4 commits in af696ce8ea526445590ae0ca66a8128d2a95a69a..3710b0cae783d0bcd2b42452a63b081473f5970a 2021-07-20 11:38:03 -0400 to 2021-07-26 11:34:46 -0700 - Add more consistent headings and add a migration section to reserving-syntax (rust-lang/edition-guide#263) - reserving-syntax.md: Expand and add detail (rust-lang/edition-guide#249) - Fix typo in or-patterns section (rust-lang/edition-guide#262) - Fix typo (rust-lang/edition-guide#261)

JohnTitor · 2021-07-27T06:39:57Z

@bors r+ rollup=never p=8

bors · 2021-07-27T06:39:59Z

📌 Commit 4ae56e4 has been approved by JohnTitor

bors · 2021-07-27T08:41:48Z

⌛ Testing commit 4ae56e4 with merge c6f4c1bc62365ea81672498ff42bceb66eaef5c8...

rust-log-analyzer · 2021-07-27T09:36:07Z

The job dist-x86_64-apple failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

      Memory: 14 GB
      Boot ROM Version: VMW71.00V.13989454.B64.1906190538
      Apple ROM Info: [MS_VM_CERT/SHA1/27d66596a61c48dd3dc7216fd715126e33f59ae7]Welcome to the Virtual Machine
      SMC Version (system): 2.8f0
      Serial Number (system): VMoxJBxBrfw3

hw.ncpu: 3
hw.byteorder: 1234
hw.memsize: 15032385536
---
[  6%] Building CXX object lib/Core/CMakeFiles/lldCore.dir/Error.cpp.o
[  7%] Building CXX object lib/Core/CMakeFiles/lldCore.dir/DefinedAtom.cpp.o
[  8%] Building CXX object Common/CMakeFiles/lldCommon.dir/Args.cpp.o
error: failed to execute compile
caused by: Failed to send data to or receive data from server
caused by: Failed to read response header
caused by: Connection reset by peer (os error 54)
error: failed to execute compile
caused by: Failed to send data to or receive data from server
caused by: Failed to read response header
caused by: Connection reset by peer (os error 54)
make[2]: *** [lib/Core/CMakeFiles/lldCore.dir/DefinedAtom.cpp.o] Error 2
make[2]: *** Waiting for unfinished jobs....
make[2]: *** [Common/CMakeFiles/lldCommon.dir/Args.cpp.o] Error 2
make[1]: *** [Common/CMakeFiles/lldCommon.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
error: Connection to server timed out
make[2]: *** [lib/Core/CMakeFiles/lldCore.dir/Error.cpp.o] Error 2
 finished in 29.691 seconds
make[1]: *** [lib/Core/CMakeFiles/lldCore.dir/all] Error 2
Build completed unsuccessfully in 0:46:22
make: *** [all] Error 2
command did not execute successfully, got: exit status: 2


build script failed, must exit now', /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/cmake-0.1.44/src/lib.rs:885:5

bors · 2021-07-27T09:44:16Z

💔 Test failed - checks-actions

JohnTitor · 2021-07-27T10:52:05Z

caused by: Connection reset by peer (os error 54)

@bors retry

JohnTitor · 2021-07-27T10:53:27Z

Recreated a bigger rollup, @bors r-

estebank and others added 17 commits July 1, 2021 11:19

Avoid ICE on type error recovery

8ea5362

Fix rust-lang#86756

get rid of NoMirFor error variant

3b9f811

macos current_exe using directly libc instead.

5407b42

fix typo: whenver -> whenever

cccd4e2

Remove ASCII fast path from rustc_lexer::{is_id_continue, is_id_start}

a397fdc

update unicode-xid dependency

de27d68

Update cargo

38663c0

Update books

07727c8

Rollup merge of rust-lang#86764 - estebank:issue-86756, r=pnkfelix

7f71da8

Avoid ICE on type error recovery Fix rust-lang#86756

Rollup merge of rust-lang#87427 - RalfJung:no-mir-for, r=oli-obk

26dd4af

get rid of NoMirFor error variant The only place where we throw that error, it is very quickly caught again and turned into a different error. So raise that other error immediately.

Rollup merge of rust-lang#87446 - devnexen:macos_update, r=dtolnay

bb68cc1

macos current_exe using directly libc instead.

Rollup merge of rust-lang#87494 - midgleyc:comment-typos, r=joshtriplett

282ac09

fix typo: whenver -> whenever Fix a typo in a comment in RefCell: "whenver" -> "whenever".

Rollup merge of rust-lang#87499 - ibraheemdev:patch-6, r=dtolnay

84962a7

Remove ASCII fast path from `rustc_lexer::{is_id_continue, is_id_start}` `unicode_xid` now has a fast path built-in: unicode-rs/unicode-xid@122b387

rustbot added the rollup A PR which is a rollup label Jul 27, 2021

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 27, 2021

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 27, 2021

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 27, 2021

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 27, 2021

JohnTitor closed this Jul 27, 2021

JohnTitor deleted the rollup-p6js7nm branch July 27, 2021 10:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 8 pull requests #87505

Rollup of 8 pull requests #87505

JohnTitor commented Jul 27, 2021

JohnTitor commented Jul 27, 2021

bors commented Jul 27, 2021

bors commented Jul 27, 2021

rust-log-analyzer commented Jul 27, 2021

bors commented Jul 27, 2021

JohnTitor commented Jul 27, 2021

JohnTitor commented Jul 27, 2021

Rollup of 8 pull requests #87505

Rollup of 8 pull requests #87505

Conversation

JohnTitor commented Jul 27, 2021

JohnTitor commented Jul 27, 2021

bors commented Jul 27, 2021

bors commented Jul 27, 2021

rust-log-analyzer commented Jul 27, 2021

bors commented Jul 27, 2021

JohnTitor commented Jul 27, 2021

JohnTitor commented Jul 27, 2021