Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid suggestions for non-ASCII characters in byte constants #87659

Merged
merged 1 commit into from
Aug 2, 2021
Merged

Fix invalid suggestions for non-ASCII characters in byte constants #87659

merged 1 commit into from
Aug 2, 2021

Conversation

FabianWolff
Copy link
Contributor

Fixes #87397.

@rust-highfive
Copy link
Collaborator

r? @davidtwco

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 31, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
davidtwco
davidtwco approved these changes Aug 1, 2021
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can r=me unless you want to address any of the comments.

src/test/ui/suggestions/multibyte-escapes.rs Show resolved Hide resolved
src/test/ui/attributes/key-value-non-ascii.stderr Show resolved Hide resolved
@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Aug 1, 2021

📌 Commit c1abb6f has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 1, 2021
@FabianWolff
Copy link
Contributor Author

@davidtwco Thanks for the review!

@camsteffen camsteffen mentioned this pull request Aug 2, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 2, 2021
@bors
Auto merge of rust-lang#87698 - camsteffen:rollup-yvjfc26, r=camsteffen
6be8a06 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#86176 (Implement a `explicit_generic_args_with_impl_trait` feature gate)
 - rust-lang#87654 (Add documentation for the order of Option and Result)
 - rust-lang#87659 (Fix invalid suggestions for non-ASCII characters in byte constants)
 - rust-lang#87673 (Tweak opaque type mismatch error)
 - rust-lang#87687 (Inline some macros)
 - rust-lang#87690 (Add missing "allocated object" doc link to `<*mut T>::add`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4380056 into rust-lang:master Aug 2, 2021
@rustbot rustbot added this to the 1.56.0 milestone Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.56.0
Development

Successfully merging this pull request may close these issues.

\xHH escaping suggestions are wrong for characters that are too big
6 participants
@FabianWolff @rust-highfive @rust-log-analyzer @davidtwco @bors @rustbot