Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#[inline] non-generic pub fns in rustc_target::abi and ty::layout. #88326

Merged
merged 1 commit into from
Aug 27, 2021

Conversation

eddyb
Copy link
Member

@eddyb eddyb commented Aug 25, 2021

Mostly doing this as a perf curiosity, having spotted that #[inline] usage is a bit spotty.

@rust-highfive
Copy link
Collaborator

r? @oli-obk

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 25, 2021
@eddyb
Copy link
Member Author

eddyb commented Aug 25, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 25, 2021
@bors
Copy link
Contributor

bors commented Aug 25, 2021

⌛ Trying commit 94b11f66fa9b994d0f3be4b7807f1bc6e364edde with merge 54d4ab1b221a642ac4dd0be99a815d0061126a41...

@bors
Copy link
Contributor

bors commented Aug 25, 2021

☀️ Try build successful - checks-actions
Build commit: 54d4ab1b221a642ac4dd0be99a815d0061126a41 (54d4ab1b221a642ac4dd0be99a815d0061126a41)

@rust-timer
Copy link
Collaborator

Queued 54d4ab1b221a642ac4dd0be99a815d0061126a41 with parent 9863bf5, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (54d4ab1b221a642ac4dd0be99a815d0061126a41): comparison url.

Summary: This change led to moderate relevant improvements 🎉 in compiler performance.

  • Moderate improvement in instruction counts (up to -1.8% on full builds of ctfe-stress-4)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 25, 2021
@oli-obk
Copy link
Contributor

oli-obk commented Aug 26, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Aug 26, 2021

📌 Commit 94b11f66fa9b994d0f3be4b7807f1bc6e364edde has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 26, 2021
@bors
Copy link
Contributor

bors commented Aug 26, 2021

☔ The latest upstream changes (presumably #88308) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 26, 2021
@eddyb
Copy link
Member Author

eddyb commented Aug 26, 2021

@bors r=oli-obk

@bors
Copy link
Contributor

bors commented Aug 26, 2021

📌 Commit efb4148 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 26, 2021
@bors
Copy link
Contributor

bors commented Aug 27, 2021

⌛ Testing commit efb4148 with merge dfd6306...

@bors
Copy link
Contributor

bors commented Aug 27, 2021

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing dfd6306 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 27, 2021
@bors bors merged commit dfd6306 into rust-lang:master Aug 27, 2021
@rustbot rustbot added this to the 1.56.0 milestone Aug 27, 2021
@eddyb eddyb deleted the inline-ty-layout-methods branch August 27, 2021 10:09
@eddyb
Copy link
Member Author

eddyb commented Aug 27, 2021

Looks like the perf run after landing was a bit of a wash, I wonder if #88308 made it harder to have improvements in layout-adjacent code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants