rustc: Remove local variable IDs from Exports
#88677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occurred in src/tools/clippy. cc @rust-lang/clippy |
|
r? @davidtwco (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 7f651948dea239fe45d6b1e564dc799ab4e3f894 has been approved by |
bors
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
bors
added
S-waiting-on-author
Local variables can never be exported.
petrochenkov
force-pushed
the
exportid
branch
from
7f65194
to
294510e
Compare
|
@bors r=davidtwco |
|
📌 Commit 294510e has been approved by |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Sep 11, 2021
rustc: Remove local variable IDs from `Export`s Local variables can never be exported.
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Sep 11, 2021
rustc: Remove local variable IDs from `Export`s Local variables can never be exported.
This was referenced Sep 11, 2021
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Sep 12, 2021
rustc: Remove local variable IDs from `Export`s Local variables can never be exported.
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Sep 12, 2021
rustc: Remove local variable IDs from `Export`s Local variables can never be exported.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 12, 2021
…arth Rollup of 7 pull requests Successful merges: - rust-lang#88336 ( Detect stricter constraints on gats where clauses in impls vs trait) - rust-lang#88677 (rustc: Remove local variable IDs from `Export`s) - rust-lang#88699 (Remove extra unshallow from cherry-pick checker) - rust-lang#88709 (generic_const_exprs: use thir for abstract consts instead of mir) - rust-lang#88711 (Rework DepthFirstSearch API) - rust-lang#88810 (rustdoc: Cleanup `clean` part 1) - rust-lang#88813 (explicitly link to external `ena` docs) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
|
The rollup caused an instruction count increase on perf, do you think that's due to this PR? |
|
It seems unlikely, this PR is a type-level refactoring that shouldn't change anything at runtime. |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Sep 28, 2021
rustc: Remove local variable IDs from `Export`s Local variables can never be exported.
JohnTitor
added a commit
to JohnTitor/rust-semverver
that referenced
this pull request
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local variables can never be exported.