Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow simd_shuffle to accept vectors of any length #88855

Merged
merged 2 commits into from
Sep 19, 2021

Conversation

calebzulawski
Copy link
Member

cc @rust-lang/project-portable-simd @workingjubilee

@rust-highfive
Copy link
Collaborator

r? @nagisa

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 11, 2021
@nagisa
Copy link
Member

nagisa commented Sep 12, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Sep 12, 2021

📌 Commit 1b3fe75 has been approved by nagisa

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 12, 2021
@workingjubilee workingjubilee added the A-SIMD Area: SIMD (Single Instruction Multiple Data) label Sep 13, 2021
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Sep 14, 2021
… r=nagisa

Allow simd_shuffle to accept vectors of any length

cc `@rust-lang/project-portable-simd` `@workingjubilee`
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Sep 14, 2021
… r=nagisa

Allow simd_shuffle to accept vectors of any length

cc ``@rust-lang/project-portable-simd`` ``@workingjubilee``
@calebzulawski
Copy link
Member Author

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 16, 2021
@workingjubilee
Copy link
Member

workingjubilee commented Sep 16, 2021

While experimenting with more complex actual uses of this than it was initially tested for, Caleb found a snag in the current version that causes an ICE if it is hit. Boxy helped draft a fix but we figured we might as well push a new revision here, since it seems like, due to recent queue issues, following up in another PR would take even longer.

@calebzulawski
Copy link
Member Author

calebzulawski commented Sep 16, 2021

The simple tests I wrote did not catch that if the constant arg needed any evaluation, it was not monomorphized and crashed. I added a more complex test case that covers this scenario. Should be good to go now.

@nagisa
Copy link
Member

nagisa commented Sep 17, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Sep 17, 2021

📌 Commit 4a4ca94 has been approved by nagisa

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 17, 2021
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Sep 19, 2021
… r=nagisa

Allow simd_shuffle to accept vectors of any length

cc `@rust-lang/project-portable-simd` `@workingjubilee`
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 19, 2021
Rollup of 10 pull requests

Successful merges:

 - rust-lang#87960 (Suggest replacing an inexisting field for an unmentioned field)
 - rust-lang#88855 (Allow simd_shuffle to accept vectors of any length)
 - rust-lang#88966 (Check for shadowing issues involving block labels)
 - rust-lang#88996 (Fix linting when trailing macro expands to a trailing semi)
 - rust-lang#89017 (fix potential race in AtomicU64 time monotonizer)
 - rust-lang#89021 (Add a separate error for `dyn Trait` in `const fn`)
 - rust-lang#89051 (Add intra-doc links and small changes to `std::os` to be more consistent)
 - rust-lang#89053 (refactor: VecDeques IntoIter fields to private)
 - rust-lang#89055 (Suggest better place to add call parentheses for method expressions wrapped in parentheses)
 - rust-lang#89081 (Fix a typo)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e675073 into rust-lang:master Sep 19, 2021
@rustbot rustbot added this to the 1.57.0 milestone Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-SIMD Area: SIMD (Single Instruction Multiple Data) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants